Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend multi-window support to Electron (#11642) #49

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Extend multi-window support to Electron (#11642) #49

wants to merge 2 commits into from

Commits on Oct 14, 2022

  1. Add secondary window support for Electron. 

    Fixes eclipse-theia#11642

The main change is to prevent the secondary window from closing until
the extracted widget is removed from the window. This includes waiting
until any close handling (including dialogs) are finished.
Since we cannot reliably prevent closing windows in the browser case,
we either save or discard unsaved changes according to the autosave
settings

Contributed on behalf of ST Microelectronics.

Signed-off-by: Thomas Mäder <[email protected]>
    @tsmaeder
    tsmaeder committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    ea8db47 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Some changes to prevent "Illegal access" 

    Signed-off-by: Thomas Mäder <[email protected]>
    @tsmaeder
    tsmaeder committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    3ddebe4 View commit details
    Browse the repository at this point in the history