Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade-to-vite #119

Merged
merged 35 commits into from
Jun 11, 2024
Merged
Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
8392ec1
chore: remove deprecated extension recommendation
mayank1513 Jun 6, 2024
87dea3d
chore: Migrate to using vite
mayank1513 Jun 6, 2024
a224978
fix: Update dependencies
mayank1513 Jun 6, 2024
8cfc29a
Force dev and build port to 3000
mayank1513 Jun 6, 2024
0fcf5ea
Add vitest for unit testing
mayank1513 Jun 6, 2024
67d35cd
fix: vite build and vitest unite testing
mayank1513 Jun 6, 2024
57aa8c2
Update github workflow
mayank1513 Jun 6, 2024
3675703
remove pnpm-lock file
mayank1513 Jun 6, 2024
6599a83
fix: update package-lock
mayank1513 Jun 6, 2024
6682b4b
rename output directory to build
mayank1513 Jun 6, 2024
b66a078
chore: remove unnecessary dist from .gitignore
mayank1513 Jun 7, 2024
376aed4
chore: Move devDependencies under appropreate field in package.json
mayank1513 Jun 7, 2024
7fc1388
fix: Add jsdom as devDependency
mayank1513 Jun 7, 2024
f428ab2
fix: fix typo to exclude main.tsx from test coverage
mayank1513 Jun 7, 2024
46f7cf3
feat: Increase test coverage and clarify testing scope
mayank1513 Jun 7, 2024
ebc206c
Update lint config and fix lint issues
mayank1513 Jun 7, 2024
1127a52
refactor: refactor code for better readability and remove tech debt
mayank1513 Jun 7, 2024
3065bbb
refactor: split into smaller components
mayank1513 Jun 7, 2024
705386e
fix: add start-server-and-test as devDep to fic cypress:ci
mayank1513 Jun 7, 2024
91b4fbd
feat: Install and configure prettier for consistant formatting
mayank1513 Jun 7, 2024
a27a0cb
chore: Updated Kanban board
mayank1513 Jun 7, 2024
dab68e8
Fix the vite deprecatino warning
mayank1513 Jun 7, 2024
98af842
fix: cypress - migrate to latest specs
mayank1513 Jun 7, 2024
67e2cb3
rename "preview" script to "start"
mayank1513 Jun 7, 2024
3030adf
Build the app before running cypress:ci as vite preview does not buil…
mayank1513 Jun 10, 2024
8592a7c
Touchup
mayank1513 Jun 10, 2024
3168db5
fix: Fix cypress test issues
mayank1513 Jun 10, 2024
35d10db
Try updating selectors for MUI Autocomplete
mayank1513 Jun 10, 2024
39498d9
Try updating selectors for MUI Autocomplete
mayank1513 Jun 10, 2024
4edd211
Try updating selectors for MUI Autocomplete
mayank1513 Jun 10, 2024
13a7c33
fix: Fix cypress tests
mayank1513 Jun 10, 2024
1150ed9
Try equating to undefined
mayank1513 Jun 10, 2024
3786b3d
Update ci to run on merge to master and in pull requests
lucas-koehler Jun 11, 2024
8650cc9
fix eslint error in cypress config
lucas-koehler Jun 11, 2024
fb31707
regenerate package-lock
lucas-koehler Jun 11, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
module.exports = {
root: true,
env: { browser: true, es2020: true },
extends: [
'eslint:recommended',
'plugin:@typescript-eslint/recommended',
'plugin:react-hooks/recommended',
],
ignorePatterns: ['dist', '.eslintrc.cjs'],
parser: '@typescript-eslint/parser',
plugins: ['react-refresh'],
rules: {
'react-refresh/only-export-components': [
'warn',
{ allowConstantExport: true },
],
},
}
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- uses: actions/setup-node@v1
- uses: actions/setup-node@v4
with:
node-version: '10.x'
node-version: '20.x'
- run: npm ci
- run: npm run cypress:ci
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ bower_components

# Compiled binary addons (http://nodejs.org/api/addons.html)
build/Release

# Dependency directories
node_modules/
jspm_packages/
Expand Down
1 change: 1 addition & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
package-lock.json
7 changes: 7 additions & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"singleQuote": true,
"tabWidth": 2,
"arrowParens": "avoid",
"jsxBracketSameLine": true,
"bracketSameLine": true
}
29 changes: 29 additions & 0 deletions .tkb
mayank1513 marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
{
"scope": "Workspace",
"tasks": {
"task-qOwN6wAbcOwvCa1jGY-Tj": {
"id": "task-qOwN6wAbcOwvCa1jGY-Tj",
"description": "fix/update cypress tests",
"columnId": "column-todo"
}
},
"columns": [
{
"id": "column-todo",
"title": "To do",
"tasksIds": [
"task-qOwN6wAbcOwvCa1jGY-Tj"
]
},
{
"id": "column-doing",
"title": "Doing",
"tasksIds": []
},
{
"id": "column-done",
"title": "Done",
"tasksIds": []
}
]
}
2 changes: 1 addition & 1 deletion .vscode/extensions.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// List of extensions which should be recommended for users of this workspace.
"recommendations": [
"esbenp.prettier-vscode",
"ms-vscode.vscode-typescript-tslint-plugin"
"mayank1513.trello-kanban-task-board"
mayank1513 marked this conversation as resolved.
Show resolved Hide resolved
],
// List of extensions recommended by VS Code that should not be recommended for users of this workspace.
"unwantedRecommendations": []
Expand Down
11 changes: 6 additions & 5 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"editor.formatOnSave": true,
"editor.defaultFormatter": "esbenp.prettier-vscode",
"prettier.jsxSingleQuote": true,
"prettier.singleQuote": true
}
"editor.formatOnSave": true,
"editor.defaultFormatter": "esbenp.prettier-vscode",
"prettier.jsxSingleQuote": true,
"prettier.singleQuote": true,
"mayank1513.trello-kanban.Workspace.filePath": ".tkb"
mayank1513 marked this conversation as resolved.
Show resolved Hide resolved
}
11 changes: 11 additions & 0 deletions cypress.config.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { defineConfig } from 'cypress'

export default defineConfig({
e2e: {
// We've imported your old cypress plugins here.
// You may want to clean this up later by importing these.
setupNodeEvents(on, config) {
return require('./cypress/plugins/index.js')(on, config)
},
},
})
1 change: 0 additions & 1 deletion cypress.json

This file was deleted.

File renamed without changes.
File renamed without changes.
13 changes: 13 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<link rel="icon" type="image/svg+xml" href="/vite.svg" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>JSONForms React Starter</title>
</head>
<body>
<div id="root"></div>
<script type="module" src="/src/main.tsx"></script>
</body>
</html>
Loading