Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildsystem switched to gyp and updated to v8 4.2 #88

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

ReneHollander
Copy link

I just wanted to put this pull request out there. It's not completely finished yet but it should be a solid base for future work. Here is a list of things that still need to be done:

  • Update to even newer v8 version
  • Finish new library loader
  • Finalize build script to handle publishing of build artifacts

Here are some things I changed:

  • Switched to gyp as a build system to allow for better integration of newer v8 versions
  • Improved library loader to handle different versions of the library
  • Switched to Gradle as a build system because it allows for better automation of the build (The gradle script also handles building of the native code. Use ./gradlew native_ to build)
  • I mainly tested building on Linux, but Windows and Mac worked. Android builds are also possible

Sidenote: I cloned the io.js repository and removed all io.js related code and just added the two source files of this project. This was not only really easy, but every version of v8 should work. Just copy the source files into native/deps/v8 and compile it. If this doesn't work just copy the deps/v8 directory of io.js into the directory and it should work.

@ReneHollander
Copy link
Author

Something to mention: The native part should compile on every platform v8 compiles on without any changes to the build files. Only a shell script in native/ has to be added and the Gradle script needs another task. If the library loader doesn't already have the code to detect the operating system it should be simple to add.

@irbull
Copy link
Member

irbull commented Sep 2, 2015

Wow! Thanks. I'll take a look at this later tonight or tomorrow!
On Sep 1, 2015 7:10 PM, "Rene Hollander" [email protected] wrote:

Something to mention: The native part should compile on every platform
without any changes to the build files. Only a shell script in native/
has to be added and the Gradle script needs another task. If the library
loader doesn't already have the code to detect the operating system it
should be simple to add.


Reply to this email directly or view it on GitHub
#88 (comment).

@irbull irbull force-pushed the master branch 13 times, most recently from 8c1ca7d to f18cca7 Compare April 12, 2016 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants