Use use assertRegex instead of deprecated assertRegexpMatches #7496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates cppgentests.py to use assertRegex instead of assertRegexpMatches which has been deprecated in Python 3.2 [1] and removed in Python 3.12. This caused failures on RISC-V since Debian port ships only Python 3.12.7 (at the time of writing. [1]: https://docs.python.org/release/3.11.0/library/unittest.html#unittest.TestCase.assertRegex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My personal RISC-V CI jobs started failing recently due to jitbuilder's apigen tests
using assertRegexpMatches.
assertRegexpMatches has been deprecated in Python 3.2 and compatibility
alias was apparently removed in Python 3.12. Howeve, Debian Sid (which is
used on CI nodes) now only ships Python 3.12, so tests started failing.
This PR updates cppgentests.py to use assertRegex instead of
assertRegexpMatches.