Fix error: comparison of unsigned expression < 0 is always false

Fixes: #7454 Signed-off-by: Babneet Singh <[email protected]>
eclipse · Sep 6, 2024 · 9f1aa51 · 9f1aa51
1 parent 10fdf65
commit 9f1aa51
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/thread/common/omrthreadattr.c b/thread/common/omrthreadattr.c
@@ -33,7 +33,6 @@
 #include "omrthreadattr.h"
 
 #define J9THREAD_ATTR_IS_VALID(attr) ((attr) && (*(attr)) && ((*(attr))->size == sizeof(omrthread_attr)))
-#define J9THREAD_VALUE_OUT_OF_RANGE(val, lo, hi) (((val) < (lo)) || ((val) > (hi)))
 
 static intptr_t failedToSetAttr(intptr_t rc);
 
@@ -220,7 +219,7 @@ omrthread_attr_set_priority(omrthread_attr_t *attr, omrthread_prio_t priority)
 		return J9THREAD_ERR_INVALID_ATTR;
 	}
 
-	if (J9THREAD_VALUE_OUT_OF_RANGE(priority, J9THREAD_PRIORITY_MIN, J9THREAD_PRIORITY_MAX)) {
+	if (!J9THREAD_VALUE_WITHIN_RANGE(priority, J9THREAD_PRIORITY_MIN, J9THREAD_PRIORITY_MAX)) {
 		return J9THREAD_ERR_INVALID_VALUE;
 	}
 

diff --git a/thread/common/omrthreadattr.h b/thread/common/omrthreadattr.h
@@ -42,6 +42,8 @@ typedef struct omrthread_attr {
 	const char *name;
 } omrthread_attr;
 
++#define J9THREAD_VALUE_WITHIN_RANGE(val, lo, hi) (((val) >= (lo)) && ((val) <= (hi)))
+
 #ifdef __cplusplus
 }
 #endif

diff --git a/thread/unix/omrthreadattr.c b/thread/unix/omrthreadattr.c
@@ -39,7 +39,6 @@
 #include "unix/unixthreadattr.h"
 
 #define J9THREAD_ATTR_IS_VALID(attr) ((attr) && (*(attr)) && ((*(attr))->size == sizeof(unixthread_attr)))
-#define J9THREAD_VALUE_OUT_OF_RANGE(val, lo, hi) (((val) < (lo)) || ((val) > (hi)))
 
 static intptr_t setStacksize(pthread_attr_t *pattr, uintptr_t stacksize);
 static intptr_t setPriority(pthread_attr_t *pattr, omrthread_prio_t priority);
@@ -288,7 +287,7 @@ omrthread_attr_set_priority(omrthread_attr_t *attr, omrthread_prio_t priority)
 		return J9THREAD_SUCCESS;
 	}
 
-	if (J9THREAD_VALUE_OUT_OF_RANGE(priority, J9THREAD_PRIORITY_MIN, J9THREAD_PRIORITY_MAX)) {
+	if (!J9THREAD_VALUE_WITHIN_RANGE(priority, J9THREAD_PRIORITY_MIN, J9THREAD_PRIORITY_MAX)) {
 		return J9THREAD_ERR_INVALID_VALUE;
 	}
 

diff --git a/thread/zos390/omrthreadattr.c b/thread/zos390/omrthreadattr.c
@@ -32,7 +32,6 @@
 #include "unix/unixthreadattr.h"
 
 #define J9THREAD_ATTR_IS_VALID(attr) ((attr) && (*(attr)) && ((*(attr))->size == sizeof(unixthread_attr)))
-#define J9THREAD_VALUE_OUT_OF_RANGE(val, lo, hi) (((val) < (lo)) || ((val) > (hi)))
 
 static intptr_t failedToSetAttr(intptr_t rc);
 
@@ -229,7 +228,7 @@ omrthread_attr_set_priority(omrthread_attr_t *attr, omrthread_prio_t priority)
 		return J9THREAD_ERR_INVALID_ATTR;
 	}
 
-	if (J9THREAD_VALUE_OUT_OF_RANGE(priority, J9THREAD_PRIORITY_MIN, J9THREAD_PRIORITY_MAX)) {
+	if (!J9THREAD_VALUE_WITHIN_RANGE(priority, J9THREAD_PRIORITY_MIN, J9THREAD_PRIORITY_MAX)) {
 		return J9THREAD_ERR_INVALID_VALUE;
 	}