-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(routing): use graphhopper to provide GTFS based public transport routing #441
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2ed219a
feat(routing): use graphhopper to provide GTFS based public transport…
kschrab 25541ae
docs(routing): documentation for pt routing config
kschrab 85ece70
refactor(routing): use opencsv instead of javacsv for CSV parsing fro…
kschrab 7abcd47
clean(routing): exclude unused transient libraries
kschrab 789f5bc
clean(routing): resolve several checkstyle problems
kschrab 1ab6f22
clean(routing): define default navigationConfiguration
kschrab af26c87
fix(routing): fix handling of empty lines
kschrab 20dbb20
feat(routing): new UNITS class for km/h conversion
kschrab 3e0229a
docs(routing): javadoc
kschrab 875b11b
Revert "feat(routing): new UNITS class for km/h conversion"
kschrab f7e0aa9
clean(routing): use SpeedUtils for kmh conversion
kschrab e63a3c4
clean(routing): work after review
kschrab 0c51691
clean(routing): added note to not forget redesigning MultiModalLeg
kschrab File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked myself the question why
PtRouting
couldn't implementRouting
. Looking into the code this is obvious, but might also confuse others.Maybe we rename
Routing
toVehicleRouting
in line with theCVehicleRouting
config?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do so, I have the urge to rename all related components as well, such
RoutingPosition
->VehicleRoutingPosition
, and so on. That, on the other, would blow up the signatures and would require several changes in application code, which I want to avoid.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you changed the naming of
Routing
toVehicleRouting
but didn't propagate it further, correct?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that way we avoid many API-changes.