Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduced duplicatable V2XMessage functionality #390

Merged
merged 4 commits into from
May 30, 2024

Conversation

iwillitried
Copy link
Contributor

@iwillitried iwillitried commented May 16, 2024

Description

  • introducing "DuplicatableMessage" interface for V2xMessage inheritors
  • allows duplicating a specialised V2XMessage without importing it
  • used by VariableRetransmissionApp.java when retransmitting a message

Issue(s) related to this PR

  • Resolves issue: internal issue mosaic-extended#834

Affected parts of the online documentation

none

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

  • more code changes in mosaic-extended (same branch name)

@schwepmo
Copy link
Contributor

!!! Please do not refer or link explicitly to internal resources !!!

Remove the link to the issue and only refer to it by number please. Also any internal application names should not be used explicitly

Copy link
Contributor

@schwepmo schwepmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a solid solution to the problem. Nonetheless, I've added some formal concerns. Keep in mind that we try to keep the code quality of Eclipse MOSAIC at a high level, especially for newly added code.

!!! Also please remove all references (links and names) to internal code and only refer to internal issues by the issue number. !!!

…s/v2x/DuplicatableMessage.java

Co-authored-by: schwepmo <[email protected]>
@schwepmo schwepmo merged commit 2ec9187 into eclipse:main May 30, 2024
3 checks passed
@iwillitried iwillitried deleted the 834-retransmittable-v2xmessages branch June 3, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants