Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sumo): allow all utf-8 characters via traci #359

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

kschrab
Copy link
Contributor

@kschrab kschrab commented Oct 26, 2023

Description

This PR fixes a bug in the StringTraciWriter class which failed to send a string if it contained at least one UTF-8 character which is represented by more than one byte. To support all characters of the UTF-8 standard, which include characters of Arabic, Chinese, Hebrew, Japanese, Turkish, but also emoji characters, a simple fix in StringTraciWriter has been made, which now sends the length of the encoded byte array rather than the number of characters in the String via TraCI.

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

…ng more than 1 byte, e.g. 🚗

Signed-off-by: Karl Schrab <[email protected]>
@kschrab kschrab added hacktoberfest-accepted bugfix Pull requests that fixes a bug labels Oct 26, 2023
@kschrab kschrab requested a review from schwepmo October 26, 2023 15:53
@schwepmo schwepmo merged commit c2df711 into main Oct 27, 2023
@schwepmo schwepmo deleted the fix-traci-string-write branch October 27, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull requests that fixes a bug hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants