Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added keyexpr API using wasm module #91

Merged
merged 7 commits into from
Jan 16, 2025

Conversation

Charles-Schleich
Copy link
Member

@Charles-Schleich Charles-Schleich commented Jan 16, 2025

Adds

  • A Keyexpr wasm rust library (Internal)
  • The compiled binary and generated js + typescript definition files to zenoh-ts under src/key_expr
  • An interface for Key Expressions to support (join,concat,includes,intersects)

Note: currently the Key_expr .wasm + .js + .d.ts is manually copied to the zenoh-ts
It should be integrated into the build process, however it requires the user to also have wasm-pack. It is unlikely that key expressions will change in the near future (Most commits for the crate have happened over 2 years ago)

And is not something meant for the user to do.
We are not to be publishing this library to crates.io, only the zenoh-remote-api crate

Copy link

PR missing one of the required labels: {'dependencies', 'new feature', 'bug', 'internal', 'enhancement', 'breaking-change', 'documentation'}

Copy link

PR missing one of the required labels: {'bug', 'internal', 'enhancement', 'dependencies', 'new feature', 'breaking-change', 'documentation'}

@Charles-Schleich Charles-Schleich added enhancement New feature or request internal Changes not included in the changelog labels Jan 16, 2025
@milyin milyin changed the title Key expr wasm Added keyexpr API using wasm module Jan 16, 2025
@milyin milyin merged commit 8cdfe39 into eclipse-zenoh:main Jan 16, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal Changes not included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants