Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build timestamp to the manifest and enable deep aggregate inspection #3364

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Jan 15, 2024

Currently the build timestamp is only encoded in the file-name. This is then parsed back from the string into a date.

This has several drawbacks:

  • it is sometimes unreliable and usually the user won't notice that e.g. when the dependency and the build are using different formating rules for qualifiers
  • it does not work well for "standard" artifacts not build by Tycho that are probably not using qualifiers in the name

Because of this, the following changes are applied:

  • the build timestamp is read from the reactor if possible
  • the build timestamp is written to the manifest as part of the packaging
  • if parsing is not successful the manifest is inspected if it contains some well known build time stamps from either Tycho or BND
  • if thats not available the jar entry time is used as a last resort

both things can be configured but are enabled by default just in case it causes issues for the users and they rely on the old behavior.

Currently the build timestamp is only encoded in the file-name. This is
then parsed back from the string into a date.

This has several drawbacks:
- it is sometimes unreliable and usually the user won't notice that e.g.
when the dependency and the build are using different formating rules
for qualifiers
- it does not work well for "standard" artifacts not build by Tycho that
are probably not using qualifiers in the name

Because of this, the following changes are applied:
- the build timestamp is read from the reactor if possible
- the build timestamp is written to the manifest as part of the
packaging
- if parsing is not successful the manifest is inspected if it contains
some well known build time stamps from either Tycho or BND
- if thats not available the jar entry time is used as a last resort

both things can be configured but are enabled by default just in case it
causes issues for the users and they rely on the old behavior.
@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Jan 15, 2024
Copy link

Test Results

0 files   -   579  0 suites   - 579   0s ⏱️ - 3h 34m 43s
0 tests  -   382  0 ✅  -   374  0 💤  -  7  0 ❌  - 1 
0 runs   - 1 146  0 ✅  - 1 123  0 💤  - 22  0 ❌  - 1 

Results for commit f7ef039. ± Comparison against base commit 3e94902.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant