docs(dr): Add DR about empty assetSelector validator #1774
+31
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgblaumeiser
approved these changes
Jan 30, 2025
bmg13
approved these changes
Jan 30, 2025
Comment on lines
+28
to
+29
| `ContractDefinitionValidator` except it should fail the validation in case the creation/update of a contract | ||
| definition introduces an empty `assetSelector` properties. |
There was a problem hiding this comment.
nitpick: I know is indicated in the Decision, but I think this could help here as well
Suggested change
| `ContractDefinitionValidator` except it should fail the validation in case the creation/update of a contract | |
| definition introduces an empty `assetSelector` properties. | |
| `ContractDefinitionValidator` except it should fail the validation in case the creation/update of a contract | |
| definition introduces an empty `assetSelector` properties and the mentioned new toggle is enabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Adds decision record about adding a validator to block contract definitions with empty asset selector.
WHY
Part of #1773. Please refer to that issue for more details.