Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: efficient orchestration of edc negotiations https://github.com/… #910

Merged

Conversation

ds-lcapellino
Copy link
Contributor

eclipse-tractusx/sig-release/issues/931

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

stopWatch.stop();

// Assert
final long expectedTimeToCompletion = (NEGOTIATION_TIME * catalogItems.size()) / threadPoolThreads;

Check warning

Code scanning / CodeQL

Result of multiplication cast to wider type Warning test

Potential overflow in
int multiplication
before it is converted to long by use in an assignment context.
stopWatch.stop();

// Assert
final long expectedTimeToCompletion = (NEGOTIATION_TIME * assetIds.size()) / threadPoolThreads;

Check warning

Code scanning / CodeQL

Result of multiplication cast to wider type Warning test

Potential overflow in
int multiplication
before it is converted to long by use in an assignment context.
Copy link
Contributor

@ds-jhartmann ds-jhartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ds-lcapellino ds-lcapellino merged commit 935b7cd into eclipse-tractusx:main Jan 14, 2025
17 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants