-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AID] Handling of semantic annotations #54
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Find some comments below.
What I would highly recommend is to add some test-cases by either updating some samples or adding new ones.
EDIT: Some CI tests are failing which proves we should add more tests.
Co-authored-by: danielpeintner <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
- Coverage 65.23% 63.97% -1.26%
==========================================
Files 1 1
Lines 558 594 +36
Branches 224 231 +7
==========================================
+ Hits 364 380 +16
- Misses 155 173 +18
- Partials 39 41 +2 ☔ View full report in Codecov by Sentry. |
I have fixed the failing test, the assumption based code and adding the new test now |
If a TD has a semantic annotation, it is simply ignored in the conversion. This PR adds a basic support in this direction. I am not exactly satisfied since there can be many corner cases. The worst is if there is an additional context without a prefix. That would mean looking into the context for each possible unknown key. I have added a good amount of comments in the code but also adding now some in the PR review.