core: bump nsfw to ^2.1.2 #9267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-marechal
added
bug
Signed-off-by: Paul Maréchal <[email protected]>
paul-marechal
force-pushed
the
mp/bump-nsfw
branch
from
9c746c8 to
939a953
Compare
Improvements have been made to the library. Notably a bug was fixed where some folders were not picked up by the watchers if created too quickly and an issue on Windows was fixed where watching didn't work at all. This commit updates our code to use the new typings distributed by `nsfw` itself and re-enables file watching testing on Windows. Signed-off-by: Paul Maréchal <[email protected]>
paul-marechal
force-pushed
the
mp/bump-nsfw
branch
from
939a953 to
38a7424
Compare
DucNgn
approved these changes
Mar 29, 2021
vince-fugnitto
approved these changes
Mar 29, 2021
There was a problem hiding this comment.
@marechal-p I verified the changes and they look good to me:
- verified that the new dependency is license compatible.
- verified that file-watching (creation, deletion) is successfully picked up by the application.
- verified that the application successfully picks up multiple simultaneous updates (ex: a large git clone)
- CI is all green as well.
OS: Linux (Ubuntu 18.04)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Commit 1:
Commit 2:
How to test
Everything should work like before, tests should be green.
Windows:
Linux:
Review checklist
Reminder for reviewers