fix drag file with err uri #14746
Open
fix drag file with err uri #14746
+1
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
reviewed
Jan 20, 2025
There was a problem hiding this comment.
Hey @yanquer, thank you for the contribution!
In order to accept your changes, please sign the Eclipse Contributor Agreement (ECA) with the same email address that was used to create the commit.
| query: '', | ||
| fragment: '' | ||
| }); | ||
| // no use fromComponents which cause error-formated-str |
There was a problem hiding this comment.
Suggestion: I don't think it makes sense to specifically point out the wrong way of creating a URI. You can safely delete the comment.
There was a problem hiding this comment.
you're right. there is a new commit with [ECA]
yanquer
force-pushed
the
fix-drag-file
branch
from
5b6625c to
05e6a5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
when drag file, no use fromComponents which cause error-formated-str with #14724
How to test
Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers