Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add React keys in chat views #14444

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented Nov 13, 2024

What it does

Fixes React warnings in chat and chat configuration views regarding missing React keys.

Also adjusts the 'agent.tags' type from String[] to string[].

How to test

  • Send chat requests and open the AI configuration view.
  • Observe that there are no React warnings in the console

Review checklist

Reminder for reviewers

Fixes React warnings in chat and chat configuration views regarding
missing React keys.

Also adjusts the 'agent.tags' type from String[] to string[].
@planger planger self-requested a review November 13, 2024 10:21
Copy link
Contributor

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! Tested it and there are no more React issues. 👍

@sdirix sdirix merged commit 066b2d1 into eclipse-theia:master Nov 13, 2024
10 of 11 checks passed
@sdirix sdirix deleted the fix-react-keys branch November 13, 2024 10:32
@sdirix sdirix added this to the 1.56.0 milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants