fix: AI history view crashing on first use #14443
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The AI history view sometimes crashed on first use when the user tried to select an agent. This was caused by an empty agent list bound in the initial UI.
Refactors the history view by making sure that the history view is only instantiated once it is shown instead of early in application start. This avoids binding a still empty list of agent contributions to the UI.
Also adds fallback content in case there are no registered agents as the used 'SelectComponent' crashes with empty options.
Also moves the history sort change tracking outside of the widget. Previously this was broken as only the initial widget was tracked.
How to test
Crash fix
Observe that there is no longer a crash of the view
Sorting fix
Observe that the sorting button is updated on every click and keeps working
Review checklist
Reminder for reviewers