Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align chat renderer fallbacks #14459

Open
sdirix opened this issue Nov 15, 2024 · 0 comments
Open

Align chat renderer fallbacks #14459

sdirix opened this issue Nov 15, 2024 · 0 comments
Labels

Comments

@sdirix
Copy link
Member

sdirix commented Nov 15, 2024

Bug Description:

  • The chat-view-tree-widget checks whether any of the response part renderers matches to the parts to render. If there is none, it will log and render an error.
  • The horizontal-layout-part-renderer also does dispatching, however it does not have such a check. Instead it will take the first renderer, which is an arbitrary choice and may lead to runtime errors.

Steps to Reproduce:

  1. In an agent, return a HorizontalLayoutChatResponseContentImpl with a response part which can't be handled by any of the renderers.

Expected behavior

Both cases should behave the same, at minimum logging a debug message and making sure that there is no runtime error, for example by falling back to a default renderer or rendering some fallback content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant