Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugIssue#0 #11

Open
ZidongWang123 opened this issue Nov 15, 2024 · 3 comments
Open

BugIssue#0 #11

ZidongWang123 opened this issue Nov 15, 2024 · 3 comments

Comments

@ZidongWang123
Copy link
Collaborator

branch:feature/initialAgent
bug issue: run-time error
reproduce: run the brower-app and open the website, use @TerminalChatAgent to ask a question about terminal command
expected behavior: The agent should return a text(terminal command) and a button

code snippet: https://github.com/eclipsesource/theia-ai-exerciser-labcourse2024/blob/fb4c57af9658247a515aeb451b1a8f34cdca4aa5/exerciser/src/browser/terminal-chat-agent/terminal-chat-agent.ts#L114C1-L123C16

@ZidongWang123
Copy link
Collaborator Author

@JonasHelming

@sdirix
Copy link
Member

sdirix commented Nov 15, 2024

Hi @ZidongWang123, I had a look at the issue.

The problem is that the current Theia AI command response renderer only takes over rendering in case the command response part has an actual command set, although the command is not used when a custom handler is handed over.

As you don't hand over a command, the command response renderer will not take over. In fact, no renderer will take priority, leading to the first one registered to take over. For me that was the horizontal renderer which then produced an error.

I will make sure that we fix that in Theia AI. Until then you can just hand over a non-existing command as it will not be used anyway, e.g. like this:

new CommandChatResponseContentImpl({id: 'custom-command'}, customCallback)

@sdirix
Copy link
Member

sdirix commented Nov 15, 2024

I opened issues eclipse-theia/theia#14458 and eclipse-theia/theia#14459 to tackle the error upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants