-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix circular imports when importing ReactDialog
Fixes #14347 Contributed on behalf of Toro Cloud Signed-off-by: Rannie Peralta <[email protected]>
- Loading branch information
1 parent
c1e4279
commit 257cee7
Showing
2 changed files
with
32 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import { expect } from 'chai'; | ||
import * as React from 'react'; | ||
import { enableJSDOM } from '../test/jsdom'; | ||
|
||
let disableJSDOM = enableJSDOM(); | ||
|
||
import { ReactDialog } from './react-dialog' | ||
|
||
class MyDialog extends ReactDialog<void> { | ||
constructor() { | ||
super({ title: '' }) | ||
} | ||
|
||
override get value(): void { | ||
return; | ||
} | ||
|
||
protected override render(): React.ReactNode { | ||
return <></> | ||
} | ||
} | ||
|
||
describe('ReactDialog', () => { | ||
before(() => disableJSDOM = enableJSDOM()); | ||
after(() => disableJSDOM()); | ||
|
||
it('should be extended', () => { | ||
const dialog = new MyDialog() | ||
expect(dialog).to.be.instanceOf(ReactDialog) | ||
}) | ||
}) |