Skip to content

Commit

Permalink
Fix circular imports when importing ReactDialog
Browse files Browse the repository at this point in the history
Fixes #14347

Contributed on behalf of Toro Cloud

Signed-off-by: Rannie Peralta <[email protected]>
  • Loading branch information
rannp-toro-cloud committed Oct 25, 2024
1 parent c1e4279 commit 257cee7
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 1 deletion.
2 changes: 1 addition & 1 deletion packages/core/src/browser/dialogs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import { injectable, inject } from 'inversify';
import { Disposable, MaybePromise, CancellationTokenSource, nls } from '../common';
import { Key } from './keyboard/keys';
import { Widget, BaseWidget, Message, addKeyListener, codiconArray } from './widgets';
import { Widget, BaseWidget, Message, addKeyListener, codiconArray } from './widgets/widget';
import { FrontendApplicationContribution } from './frontend-application-contribution';

@injectable()
Expand Down
31 changes: 31 additions & 0 deletions packages/core/src/browser/dialogs/react-dialog.spec.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import { expect } from 'chai';
import * as React from 'react';
import { enableJSDOM } from '../test/jsdom';

let disableJSDOM = enableJSDOM();

import { ReactDialog } from './react-dialog'

class MyDialog extends ReactDialog<void> {
constructor() {
super({ title: '' })
}

override get value(): void {
return;
}

protected override render(): React.ReactNode {
return <></>
}
}

describe('ReactDialog', () => {
before(() => disableJSDOM = enableJSDOM());
after(() => disableJSDOM());

it('should be extended', () => {
const dialog = new MyDialog()
expect(dialog).to.be.instanceOf(ReactDialog)
})
})

0 comments on commit 257cee7

Please sign in to comment.