Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve connection settings in browser application #441

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented Jan 16, 2025

What it does

Configures 'reloadOnReconnect' and 'frontendConnectionTimeout' in the browser application to improve the user experience.

Resolves eclipse-theia/theia#14516

How to test

Run the Browser application and check the connection behavior after a few minutes. See eclipse-theia/theia#14516 for the problematic behavior

Review checklist

Reminder for reviewers

Configures 'reloadOnReconnect' and 'frontendConnectionTimeout' in the
browser application to improve the user experience.

Resolves eclipse-theia/theia#14516
@jfaltermeier jfaltermeier self-requested a review January 17, 2025 08:23
Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdirix
Copy link
Member Author

sdirix commented Jan 20, 2025

Locally I was not able to reproduce the original issue so it might only be occurring in real-world deployments. Would you like to merge anyway?

@jfaltermeier jfaltermeier merged commit 31ce2ec into master Jan 20, 2025
5 of 6 checks passed
@jfaltermeier jfaltermeier deleted the improve-browser-connections branch January 20, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue in theia with after network disconnection
2 participants