Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package-portlet): package-portlet enabled for default installation #2286

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

ag4ums
Copy link
Contributor

@ag4ums ag4ums commented Jan 24, 2024

Please provide a summary of your changes here.

  • Which issue is this pull request belonging to and how is it solving it? (Refer to issue here)
  • Did you add or update any new dependencies that are required for your change?

Issue: Closes #2285

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

How should these changes be tested by the reviewer?
Have you implemented any additional tests?

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@ag4ums ag4ums added the needs general test This is general testing, meaning that there is no org specific issue to check for label Jan 24, 2024
@KoukiHama KoukiHama self-assigned this Jan 24, 2024
@KoukiHama KoukiHama self-requested a review January 24, 2024 07:42
@KoukiHama
Copy link
Member

KoukiHama commented Jan 24, 2024

I think we need to change this one too.

IS_PACKAGE_PORTLET_ENABLED = Boolean.parseBoolean(props.getProperty("package.portlet.enabled", "false"));

@ag4ums ag4ums force-pushed the chore/package-portlet-enabled branch from dcaec13 to d9341ee Compare January 29, 2024 06:32
@KoukiHama KoukiHama requested a review from hoangnt2 January 30, 2024 23:59
@tienlee
Copy link
Contributor

tienlee commented Jan 31, 2024

Test successful.

@KoukiHama KoukiHama added ready ready to merge and removed needs general test This is general testing, meaning that there is no org specific issue to check for labels Jan 31, 2024
@ag4ums ag4ums merged commit 2434e58 into eclipse-sw360:main Jan 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable package portlet by default
3 participants