Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest) : Rest Api for ECC page #2244

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

keerthi-bl
Copy link
Contributor

Please provide a summary of your changes here.

  • Which issue is this pull request belonging to and how is it solving it? (Refer to issue here)
  • Did you add or update any new dependencies that are required for your change?

Issue:
#2036

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

How should these changes be tested by the reviewer?
Have you implemented any additional tests?

http://localhost:8080/resource/api/ecc?page=0&page_entries=3&sort=name%2Cdesc

Sample response :

{
"_embedded": {
"sw360:jSONObjects": [
{
"assessor_contact_person": "",
"name": "compfeb2 (50)",
"DT_RowId": "d29b5995f30146e5ad30b84a35f42112",
"id": "d29b5995f30146e5ad30b84a35f42112",
"version": "50",
"assessor_dept": "",
"status": "OPEN",
"group": "",
"assessment_date": ""
},
{
"assessor_contact_person": "",
"name": "Test Compo 2023 1 (22.23)",
"DT_RowId": "e06f3a093ca1453085fd27c0017e6e2c",
"id": "e06f3a093ca1453085fd27c0017e6e2c",
"version": "22.23",
"assessor_dept": "",
"status": "OPEN",
"group": "",
"assessment_date": ""
},
{
"assessor_contact_person": "[email protected]",
"name": "Component5.19 (1.1)",
"DT_RowId": "2e7f86c8236e4dd299328cbe3f7f7ae0",
"id": "2e7f86c8236e4dd299328cbe3f7f7ae0",
"version": "1.1",
"assessor_dept": "DEPARTMENT",
"status": "REJECTED",
"group": "",
"assessment_date": "2023-02-03"
}
]
},
"_links": {
"first": {
"href": "http://localhost:8080/resource/api/ecc?page=0&page_entries=3"
},
"previous": {
"href": "http://localhost:8080/resource/api/ecc?page=0&page_entries=3"
},
"last": {
"href": "http://localhost:8080/resource/api/ecc?page=0&page_entries=3"
},
"curies": [
{
"href": "http://localhost:8080/resource/docs/{rel}.html",
"name": "sw360",
"templated": true
}
]
},
"page": {
"size": 3,
"totalElements": 3,
"totalPages": 1,
"number": 1
}
}

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@ag4ums ag4ums added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Dec 18, 2023
@ag4ums ag4ums requested a review from smrutis1 January 10, 2024 08:48
@keerthi-bl keerthi-bl force-pushed the feat/EccRestEndPoint branch 3 times, most recently from 4f9c92b to 5adc185 Compare January 11, 2024 05:04
@keerthi-bl
Copy link
Contributor Author

Merge conflicts resolved

@keerthi-bl keerthi-bl force-pushed the feat/EccRestEndPoint branch 2 times, most recently from 4e3c740 to 71952cf Compare January 24, 2024 09:20
@keerthi-bl
Copy link
Contributor Author

Addressed all the review comments.

@rudra-superrr
Copy link
Contributor

Testing was successful.
image

@rudra-superrr rudra-superrr removed the needs general test This is general testing, meaning that there is no org specific issue to check for label Jan 29, 2024
@rudra-superrr
Copy link
Contributor

One thing, request structure and response structure fields are not shown in api docs.

@rudra-superrr rudra-superrr added the needs general test This is general testing, meaning that there is no org specific issue to check for label Jan 29, 2024
@keerthi-bl keerthi-bl force-pushed the feat/EccRestEndPoint branch from 71952cf to ea9edb7 Compare February 5, 2024 07:01
@keerthi-bl
Copy link
Contributor Author

Review comment addressed.

@keerthi-bl keerthi-bl force-pushed the feat/EccRestEndPoint branch from ea9edb7 to ef7b82b Compare February 9, 2024 08:14
…ncorrect-error-displayed-during-comp-creation-2215

fix(importCDX): Update failed component creation error message

Reviewed by: [email protected]
Tested  by: [email protected]
@rudra-superrr
Copy link
Contributor

Code looks good.

@rudra-superrr rudra-superrr added ready ready to merge and removed needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Feb 13, 2024
@ag4ums ag4ums merged commit 891ecbc into eclipse-sw360:main Feb 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants