-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: preview in PRs from forks #194
Comments
Apparently this is by design to prevent security risks from malicious PRs.
A safe alternative would be to create a separate repository - something like score-previews where only the previews from PR are pushed. The https://eclipse-score.github.io/score would only hold main and releases. This would avoid cluttering the gh-pages ( although in theory they are deleted when the PR is merged). Nevertheless, we could still try the following:
|
Fine grained PATs do not allow branch restrictions sadly. So we could in theory create a DEPLOY_PREVIEW_TOKEN, but GH doesn't allow for it to be restricted to a specific branch ( gh-pages for us) |
The github-pages-deploy-action also allows ssh-key usage So, one could:
2, add the public key to GH
|
Is an Environment secret also a viable alternative? With review by "trusted contributors" before the action starts. Just collecting ideas. |
Problem Description
Currently PRs from forks do not have any kind of preview for the generated documentation.
The workflow is established, but it has insufficient access rights when the PR stems from a fork. Detailed explanation and potential solution at eclipse-score/.eclipsefdn#11
Task:
The text was updated successfully, but these errors were encountered: