Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: pr-preview comment #211

Closed
AlexanderLanin opened this issue Jan 23, 2025 · 4 comments · Fixed by #255
Closed

bug: pr-preview comment #211

AlexanderLanin opened this issue Jan 23, 2025 · 4 comments · Fixed by #255
Assignees
Labels
docs-as-code good first issue Good for newcomers infrastructure General Score infrastructure topics

Comments

@AlexanderLanin
Copy link
Member

AlexanderLanin commented Jan 23, 2025

For repository-local branches the preview is built correctly, unlike #194

However the comment where to find the preview is not written, see #206 and my comment
Note: #206 is from a branch, not a fork!

Error:

Run peter-evans/create-or-update-comment@v4
/home/runner/work/_actions/peter-evans/create-or-update-comment/v4/dist/index.js:4695
const error = new requestError.RequestError(toErrorMessage(data), status, {
^
RequestError [HttpError]: Resource not accessible by integration
at /home/runner/work/_actions/peter-evans/create-or-update-comment/v4/dist/index.js:4695:21
at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
status: 403,

Initial analysis:

  • workflow may be missing issue: write permissions

Task:

  • investigate whether the initial assumption is reasonable
  • integrate the fix
@nicu1989
Copy link
Contributor

At first look it seems that fork based PRs dont push anything to gh_pages(https://github.com/eclipse-score/score/commits/gh-pages/), only native PRs do. I will look into the workflows and actions further.

@AlexanderLanin
Copy link
Member Author

yes forks suffer from a different problem! See #194

@nicu1989 nicu1989 moved this from Todo to In Progress in Operational (Tooling/Infrastructure) Jan 30, 2025
@nicu1989
Copy link
Contributor

I think the issue might be due to missing permissions for the job docs-deploy but since I cannot test any fix due to contributor rights(I can create a PR only from fork, and forks dont publish docs right now) I`m not sure.

    permissions:
      pull-requests: write

@AlexanderLanin
Copy link
Member Author

I'll try your fix on a branch here, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-as-code good first issue Good for newcomers infrastructure General Score infrastructure topics
Projects
Development

Successfully merging a pull request may close this issue.

2 participants