-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate ARCH_X86 and WS_WPF constants and constant for ppc64le architecture in o.e.core.runtime.Platform #1576
Deprecate ARCH_X86 and WS_WPF constants and constant for ppc64le architecture in o.e.core.runtime.Platform #1576
Conversation
This pull request changes some projects for the first time in this development cycle.
An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patch
Further information are available in Common Build Issues - Missing version increments. |
Test Results 1 758 files ±0 1 758 suites ±0 1h 26m 46s ⏱️ - 15m 27s For more details on these errors, see this check. Results for commit 780ea05. ± Comparison against base commit 44074c7. ♻️ This comment has been updated with latest results. |
7f5cfc5
to
e9c851c
Compare
Besides deprecating the not anymore supported arch Furthermore this also updates the list of known arch and WS returned by the Platform to the values that are actually supported nowadays. |
runtime/bundles/org.eclipse.core.runtime/src/org/eclipse/core/runtime/Platform.java
Outdated
Show resolved
Hide resolved
e9c851c
to
39254ed
Compare
and update the list of known architectures and window-systems
39254ed
to
780ea05
Compare
Adjust it to the available/known architectures since the update in eclipse-platform/eclipse.platform#1576 And simplify AbstractTargetEditorTest.
Adjust it to the available/known architectures since the update in eclipse-platform/eclipse.platform#1576 And simplify AbstractTargetEditorTest.
Just wondering if even such fundamental constants should be tagged "forRemoval", with a longer time span. Do we have some guidance why that was not done here, or is it just forgetting that this is meanwhile possible? :) |
As far as I can tell x86 32-bit is not supported anymore for any OS just like WPF on Windows.
Or can any tell if it's different?
Additionally show constant values in
@code
elements.