Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ARCH_X86 and WS_WPF constants and constant for ppc64le architecture in o.e.core.runtime.Platform #1576

Merged

Conversation

HannesWell
Copy link
Member

As far as I can tell x86 32-bit is not supported anymore for any OS just like WPF on Windows.

Or can any tell if it's different?

Additionally show constant values in @code elements.

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 0795eeda80bce99df9614412d4f27025ed67d94f Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Tue, 1 Oct 2024 20:56:11 +0000
Subject: [PATCH] Version bump(s) for 4.34 stream


diff --git a/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF b/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
index 69bf0d4e5b..a72ea8937c 100644
--- a/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
+++ b/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
-Bundle-Version: 3.31.100.qualifier
+Bundle-Version: 3.31.200.qualifier
 Bundle-SymbolicName: org.eclipse.core.runtime; singleton:=true
 Bundle-Vendor: %providerName
 Bundle-Activator: org.eclipse.core.internal.runtime.PlatformActivator
-- 
2.46.1

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

Test Results

 1 758 files  ±0   1 758 suites  ±0   1h 26m 46s ⏱️ - 15m 27s
 4 170 tests ±0   4 147 ✅ ±0   22 💤 ±0  0 ❌ ±0  1 🔥 ±0 
13 107 runs  ±0  12 940 ✅ ±0  164 💤 ±0  0 ❌ ±0  3 🔥 ±0 

For more details on these errors, see this check.

Results for commit 780ea05. ± Comparison against base commit 44074c7.

♻️ This comment has been updated with latest results.

@HannesWell HannesWell force-pushed the deprecate-unsupported-arch-andws branch from 7f5cfc5 to e9c851c Compare October 2, 2024 18:09
@HannesWell HannesWell changed the title Deprecate ARCH_X86 and WS_WPF constants in o.e.core.runtime.Platform Deprecate ARCH_X86 and WS_WPF constants and constant for ppc64le architecture in o.e.core.runtime.Platform Oct 2, 2024
@HannesWell
Copy link
Member Author

Besides deprecating the not anymore supported arch x86 and window-system wpf, this now also adds the missing constant for the supported ppc64le arch.

Furthermore this also updates the list of known arch and WS returned by the Platform to the values that are actually supported nowadays.
@akurtakov or anybody else interested in this, do you want to have a look at this?

@HannesWell HannesWell force-pushed the deprecate-unsupported-arch-andws branch from e9c851c to 39254ed Compare October 2, 2024 18:52
@HannesWell HannesWell force-pushed the deprecate-unsupported-arch-andws branch from 39254ed to 780ea05 Compare October 2, 2024 20:30
@akurtakov akurtakov merged commit 1524ff1 into eclipse-platform:master Oct 3, 2024
10 of 17 checks passed
@HannesWell HannesWell deleted the deprecate-unsupported-arch-andws branch October 3, 2024 09:20
HannesWell added a commit to HannesWell/eclipse.pde that referenced this pull request Oct 3, 2024
Adjust it to the available/known architectures since the update in
eclipse-platform/eclipse.platform#1576

And simplify AbstractTargetEditorTest.
HannesWell added a commit to eclipse-pde/eclipse.pde that referenced this pull request Oct 3, 2024
Adjust it to the available/known architectures since the update in
eclipse-platform/eclipse.platform#1576

And simplify AbstractTargetEditorTest.
@Bananeweizen
Copy link
Contributor

Just wondering if even such fundamental constants should be tagged "forRemoval", with a longer time span. Do we have some guidance why that was not done here, or is it just forgetting that this is meanwhile possible? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants