-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary specific entries in build.properties #1574
Remove unnecessary specific entries in build.properties #1574
Conversation
This pull request changes some projects for the first time in this development cycle.
An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patch
Further information are available in Common Build Issues - Missing version increments. |
1822228
to
d61c99a
Compare
@@ -22,6 +22,5 @@ bin.includes = plugin.xml,\ | |||
.,\ | |||
readme.html,\ | |||
samples/,\ | |||
OSGI-INF/l10n/bundle.properties,\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW: I have a huge amount of regex based checkstyle rules at work for detecting this and similar bad things in eclipse specific files. If anyone is interested in applying them here, ping me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is for sure obsolete but I won't call it bad :-)
In any case if you like feel free to open PRs to cleanup things, I think there is no need to specifically ask for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is for sure obsolete but I won't call it bad :-)
Technically it's not bad, but for the maintenance of the code I have the opinion that every thing that's unnecessary is bad, even if it's not changed. If it exists developers will spend their precious time wondering why it's there from time to time.
In any case if you like feel free to open PRs to cleanup things, I think there is no need to specifically ask for it.
Absolutely :)
No description provided.