Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary specific entries in build.properties #1574

Merged

Conversation

HannesWell
Copy link
Member

No description provided.

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

debug/org.eclipse.debug.examples.core/META-INF/MANIFEST.MF
debug/org.eclipse.debug.examples.ui/META-INF/MANIFEST.MF
ua/org.eclipse.ua.tests.doc/META-INF/MANIFEST.MF
ua/org.eclipse.ua.tests.doc/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 7982c9f2ad459cb48e05c77d919e5cf72260f0f1 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Mon, 30 Sep 2024 18:00:17 +0000
Subject: [PATCH] Version bump(s) for 4.34 stream


diff --git a/debug/org.eclipse.debug.examples.core/META-INF/MANIFEST.MF b/debug/org.eclipse.debug.examples.core/META-INF/MANIFEST.MF
index 70b1b2f3a2..7f8b76912a 100644
--- a/debug/org.eclipse.debug.examples.core/META-INF/MANIFEST.MF
+++ b/debug/org.eclipse.debug.examples.core/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: org.eclipse.debug.examples.core;singleton:=true
-Bundle-Version: 1.6.400.qualifier
+Bundle-Version: 1.6.500.qualifier
 Bundle-Activator: org.eclipse.debug.examples.core.pda.DebugCorePlugin
 Require-Bundle: org.eclipse.core.runtime,
  org.eclipse.core.resources,
diff --git a/debug/org.eclipse.debug.examples.ui/META-INF/MANIFEST.MF b/debug/org.eclipse.debug.examples.ui/META-INF/MANIFEST.MF
index c5cf7bf2ad..f0230dc3c6 100644
--- a/debug/org.eclipse.debug.examples.ui/META-INF/MANIFEST.MF
+++ b/debug/org.eclipse.debug.examples.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: org.eclipse.debug.examples.ui;singleton:=true
-Bundle-Version: 1.8.400.qualifier
+Bundle-Version: 1.8.500.qualifier
 Bundle-Activator: org.eclipse.debug.examples.ui.pda.DebugUIPlugin
 Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
  org.eclipse.core.resources,
diff --git a/ua/org.eclipse.ua.tests.doc/META-INF/MANIFEST.MF b/ua/org.eclipse.ua.tests.doc/META-INF/MANIFEST.MF
index 4a4d03c98e..c99f21531c 100644
--- a/ua/org.eclipse.ua.tests.doc/META-INF/MANIFEST.MF
+++ b/ua/org.eclipse.ua.tests.doc/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: org.eclipse.ua.tests.doc;singleton:=true
-Bundle-Version: 1.2.500.qualifier
+Bundle-Version: 1.2.600.qualifier
 Require-Bundle: org.eclipse.ui,
  org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
  org.eclipse.equinox.http.registry;bundle-version="1.0.200",
diff --git a/ua/org.eclipse.ua.tests.doc/pom.xml b/ua/org.eclipse.ua.tests.doc/pom.xml
index e5b6bb4e91..40ce02778a 100644
--- a/ua/org.eclipse.ua.tests.doc/pom.xml
+++ b/ua/org.eclipse.ua.tests.doc/pom.xml
@@ -19,7 +19,7 @@
   </parent>
   <groupId>org.eclipse.ua</groupId>
   <artifactId>org.eclipse.ua.tests.doc</artifactId>
-  <version>1.2.500-SNAPSHOT</version>
+  <version>1.2.600-SNAPSHOT</version>
   <packaging>eclipse-test-plugin</packaging>
 
   <properties>
-- 
2.46.1

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

github-actions bot commented Sep 30, 2024

Test Results

 1 758 files  ±0   1 758 suites  ±0   1h 26m 0s ⏱️ - 7m 16s
 4 170 tests ±0   4 148 ✅ ±0   22 💤 ±0  0 ❌ ±0 
13 107 runs  ±0  12 943 ✅ ±0  164 💤 ±0  0 ❌ ±0 

Results for commit d61c99a. ± Comparison against base commit b95d0ec.

♻️ This comment has been updated with latest results.

@HannesWell HannesWell merged commit c25f2b7 into eclipse-platform:master Oct 1, 2024
17 checks passed
@HannesWell HannesWell deleted the cleanup-build.properties branch October 1, 2024 18:56
@@ -22,6 +22,5 @@ bin.includes = plugin.xml,\
.,\
readme.html,\
samples/,\
OSGI-INF/l10n/bundle.properties,\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW: I have a huge amount of regex based checkstyle rules at work for detecting this and similar bad things in eclipse specific files. If anyone is interested in applying them here, ping me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is for sure obsolete but I won't call it bad :-)

In any case if you like feel free to open PRs to cleanup things, I think there is no need to specifically ask for it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is for sure obsolete but I won't call it bad :-)

Technically it's not bad, but for the maintenance of the code I have the opinion that every thing that's unnecessary is bad, even if it's not changed. If it exists developers will spend their precious time wondering why it's there from time to time.

In any case if you like feel free to open PRs to cleanup things, I think there is no need to specifically ask for it.

Absolutely :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants