Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate resources propertytester tests to JUnit 5 #903 #1555

Conversation

HeikoKlare
Copy link
Contributor

Migrates the tests in org.eclipse.core.tests.interal.propertytester to JUnit 5.

  • Exchange JUnit 4 test annotations
  • Replace JUnit 4 assertions with JUnit 5 assertions
  • Parameterize tests

Contributes to #903

Copy link
Contributor

github-actions bot commented Sep 15, 2024

Test Results

 1 758 files  ± 0   1 758 suites  ±0   1h 26m 29s ⏱️ +51s
 4 170 tests +12   4 148 ✅ +12   22 💤 ±0  0 ❌ ±0 
13 107 runs  +36  12 943 ✅ +36  164 💤 ±0  0 ❌ ±0 

Results for commit 50cc2d0. ± Comparison against base commit 1016b36.

This pull request removes 4 and adds 16 tests. Note that renamed tests count towards both.
AutomatedResourceTests AllPropertytesterTests FilePropertyTesterTest ‑ testExistingNsRootElementFile
AutomatedResourceTests AllPropertytesterTests FilePropertyTesterTest ‑ testExistingTextFile
AutomatedResourceTests AllPropertytesterTests FilePropertyTesterTest ‑ testNonExistingNsRootElementFile
AutomatedResourceTests AllPropertytesterTests FilePropertyTesterTest ‑ testNonExistingTextFile
AutomatedResourceTests AllPropertytesterTests FilePropertyTesterTest ‑ testExistingNsRootElementFile(List)[1] []
AutomatedResourceTests AllPropertytesterTests FilePropertyTesterTest ‑ testExistingNsRootElementFile(List)[2] [kindOf]
AutomatedResourceTests AllPropertytesterTests FilePropertyTesterTest ‑ testExistingNsRootElementFile(List)[3] [useFilenameOnly]
AutomatedResourceTests AllPropertytesterTests FilePropertyTesterTest ‑ testExistingNsRootElementFile(List)[4] [kindOf, useFilenameOnly]
AutomatedResourceTests AllPropertytesterTests FilePropertyTesterTest ‑ testExistingTextFile(List)[1] []
AutomatedResourceTests AllPropertytesterTests FilePropertyTesterTest ‑ testExistingTextFile(List)[2] [kindOf]
AutomatedResourceTests AllPropertytesterTests FilePropertyTesterTest ‑ testExistingTextFile(List)[3] [useFilenameOnly]
AutomatedResourceTests AllPropertytesterTests FilePropertyTesterTest ‑ testExistingTextFile(List)[4] [kindOf, useFilenameOnly]
AutomatedResourceTests AllPropertytesterTests FilePropertyTesterTest ‑ testNonExistingNsRootElementFile(List)[1] []
AutomatedResourceTests AllPropertytesterTests FilePropertyTesterTest ‑ testNonExistingNsRootElementFile(List)[2] [kindOf]
…

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare marked this pull request as ready for review September 15, 2024 18:38
@HeikoKlare HeikoKlare force-pushed the junit5-resources-propertytester branch 3 times, most recently from 01daced to 2e5e034 Compare September 21, 2024 13:55
@HeikoKlare HeikoKlare force-pushed the junit5-resources-propertytester branch from 2e5e034 to d169779 Compare October 1, 2024 08:42
Migrates the tests in org.eclipse.core.tests.interal.propertytester to
JUnit 5.
- Exchange JUnit 4 test annotations
- Replace JUnit 4 assertions with JUnit 5 assertions
- Parameterize tests

Contributes to
eclipse-platform#903
@HeikoKlare HeikoKlare force-pushed the junit5-resources-propertytester branch from d169779 to 50cc2d0 Compare October 1, 2024 09:38
@HeikoKlare HeikoKlare merged commit b95d0ec into eclipse-platform:master Oct 1, 2024
17 checks passed
@HeikoKlare HeikoKlare deleted the junit5-resources-propertytester branch October 1, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant