Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IllegalArgumentException when styling the sticky lines #2497

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Christopher-Hermann
Copy link
Contributor

When the sticky lines are limited by the settings, the not visible sticky lines should not be styled.

Fixes #2496

When the sticky lines are limited by the settings, the not visible sticky lines should not be styled.

Fixes eclipse-platform#2496
Copy link
Member

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no time for an in-depth review, and I don't know the code at all.
I've verified my case works now without errors, thanks.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Test Results

 1 802 files   -  19   1 802 suites   - 19   1h 45m 31s ⏱️ +6s
 7 725 tests +  1   7 496 ✅ +  1  228 💤 ±0  1 ❌ ±0 
23 977 runs   - 356  23 235 ✅  - 350  741 💤  - 6  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 91383e0. ± Comparison against base commit 136afb4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"IllegalArgumentException: Argument not valid" errors reported with Sticky scrolling enabled
2 participants