Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore missing versions on required bundles for Java editor examples #2459

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

fedejeanne
Copy link
Contributor

Change the PDE preferences from "Warning" to "Ignore".

image

Change the PDE preferences from "Warning" to "Ignore".
@fedejeanne fedejeanne force-pushed the ignore_missing_version_plugin_deps branch from 00d741b to e633406 Compare October 29, 2024 13:11
@fedejeanne fedejeanne marked this pull request as ready for review October 29, 2024 13:12
@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

examples/org.eclipse.ui.examples.javaeditor/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 411235f5684d86969d96618ad552cbf6597102fb Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Tue, 29 Oct 2024 13:17:11 +0000
Subject: [PATCH] Version bump(s) for 4.34 stream


diff --git a/examples/org.eclipse.ui.examples.javaeditor/META-INF/MANIFEST.MF b/examples/org.eclipse.ui.examples.javaeditor/META-INF/MANIFEST.MF
index d2b442166d..9f67ea8815 100644
--- a/examples/org.eclipse.ui.examples.javaeditor/META-INF/MANIFEST.MF
+++ b/examples/org.eclipse.ui.examples.javaeditor/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ui.examples.javaeditor; singleton:=true
-Bundle-Version: 3.4.300.qualifier
+Bundle-Version: 3.4.400.qualifier
 Bundle-Activator: org.eclipse.ui.examples.javaeditor.JavaEditorExamplePlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

Test Results

 1 821 files  ±0   1 821 suites  ±0   1h 59m 21s ⏱️ + 11m 23s
 7 714 tests ±0   7 485 ✅  - 1  228 💤 ±0  1 ❌ +1 
24 303 runs  ±0  23 555 ✅  - 1  747 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 84ebb32. ± Comparison against base commit 4fbbe1b.

@fedejeanne
Copy link
Contributor Author

Test failure is unrelated #2458

@fedejeanne fedejeanne merged commit 76701fe into master Oct 30, 2024
9 of 14 checks passed
@akurtakov akurtakov deleted the ignore_missing_version_plugin_deps branch October 30, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants