[StickyScrolling] Move text and style calculation to StickyLine #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #2399 |
Test Results 1 821 files ±0 1 821 suites ±0 1h 51m 44s ⏱️ + 3m 14s Results for commit b5f78e5. ± Comparison against base commit 56115fc. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Christopher-Hermann
force-pushed
the
stickyScrollingRef2
branch
2 times, most recently
from
6e9cb77
to
957a3de
Compare
|
@tobiasmelcher Maybe you can have a look. I implemented your idea from the POC via the new IStickyLine interface |
tobiasmelcher
approved these changes
Oct 29, 2024
...e.ui.editors/src/org/eclipse/ui/internal/texteditor/stickyscroll/StickyScrollingControl.java
Outdated
Show resolved
Hide resolved
Move the text and style calculation to the StickyLine itself in order to enable the sticky line provider to overwrite the default behavior. This is needed to apply custom texts or custom styles for the sticky lines. Preparation for eclipse-platform#2398
Christopher-Hermann
force-pushed
the
stickyScrollingRef2
branch
from
957a3de
to
b5f78e5
Compare
|
This PR causes regression => #2496 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the text and style calculation to the StickyLine itself in order to enable the sticky line provider to overwrite the default behavior. This is needed to apply custom texts or custom styles for the sticky lines.
Preparation for #2398