Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Oomph-Setup] Add eclipse.platform.ui configuration setup #2363

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

HannesWell
Copy link
Member

Additionally add a styled and drag&drop-able Oomph Configuration button.

Part of eclipse-platform/eclipse.platform.releng.aggregator#2430

Copy link
Contributor

github-actions bot commented Oct 6, 2024

Test Results

0 files   -  1 815  0 suites   - 1 815   0s ⏱️ - 1h 44m 7s
0 tests  -  7 704  0 ✅  -  7 476  0 💤  - 228  0 ❌ ±0 
0 runs   - 24 273  0 ✅  - 23 526  0 💤  - 747  0 ❌ ±0 

Results for commit f3809dd. ± Comparison against base commit 7b0f776.

♻️ This comment has been updated with latest results.

@merks
Copy link
Contributor

merks commented Oct 7, 2024

A configuration reference is needed:

image

Drag and drop the configuration resource onto the editor of the project setup, and alt-drag the Configuration instance and drop it onto the Configuration annotation. (Ask me on slack if you need help.)

@HannesWell HannesWell force-pushed the oomph-configuration branch 2 times, most recently from f7264c7 to f3809dd Compare October 7, 2024 18:16
Additionally add a styled and drag&drop-able Oomph Configuration button
and clean-up the build instructions.

Part of eclipse-platform/eclipse.platform.releng.aggregator#2430
@HannesWell
Copy link
Member Author

A configuration reference is needed:

Drag and drop the configuration resource onto the editor of the project setup, and alt-drag the Configuration instance and drop it onto the Configuration annotation. (Ask me on slack if you need help.)

Thanks for the hint! Just added it.

Since the verification build does not test this, I'll submit this to see if the Oomph badge is generated as expected by https://ci.eclipse.org/oomph/job/setup-archiver/.

@HannesWell HannesWell merged commit 2a52383 into eclipse-platform:master Oct 7, 2024
5 of 11 checks passed
@HannesWell HannesWell deleted the oomph-configuration branch October 7, 2024 18:31
@HannesWell
Copy link
Member Author

Since the verification build does not test this, I'll submit this to see if the Oomph badge is generated as expected by https://ci.eclipse.org/oomph/job/setup-archiver/.

Worked as expected:
grafik

And the displayed content also looks good:
https://www.eclipse.org/setups/installer/?url=https://raw.githubusercontent.com/eclipse-platform/eclipse.platform.ui/master/releng/org.eclipse.ui.releng/platformUIConfiguration.setup&show=true

@merks
Copy link
Contributor

merks commented Oct 7, 2024

You must have done something right. 🤪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants