Improvement to the existing dark theme

[mvm-sap]

For the full details of the change including screenshots see issue: #2114

[iloveeclipse]

Screenshots ?

[vogella]

The sap specific styling should be done by a sap extension to the dark theme

IEclipsePreferences#org-eclipse-ui-workbench:com-sap-adt-tools-abapsource-ui {

[vogella]

Please adjust also the Linux dark theme

[github-actions]

Test Results

 1 210 files   -     4   1 210 suites   - 4   1h 8m 36s ⏱️ - 8m 4s
 7 677 tests ±    0   7 445 ✅ +246  231 💤  -  2  1 ❌ +1 
16 128 runs   - 1 024  15 614 ✅  - 760  513 💤  - 10  1 ❌ +1 

For more details on these failures, see this check.

Results for commit c509c76. ± Comparison against base commit 8534560.

This pull request skips 3 and un-skips 5 tests.

UiTestSuite org.eclipse.ui.tests.api.ApiTestSuite org.eclipse.ui.tests.api.WorkbenchPluginTest ‑ testGetImageRegistryFromAdditionalDisplay
org.eclipse.jface.text.tests.contentassist.ContextInformationTest ‑ testContextInfo_hide_focusOut
org.eclipse.urischeme.internal.registration.TestUnitWinRegistry ‑ testWinRegistry

org.eclipse.ui.genericeditor.tests.HoverTest ‑ testEnabledWhenHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testMultipleHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testProblemHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testSingleHover
org.eclipse.ui.genericeditor.tests.ShowInformationTest ‑ testInformationControl

[mvm-sap]

Please find the screenshots in the issue link provided : #2114

[thomasritter]

@vogella Adjusting the themes is very expensive. It took one person 3+ months to learn about how the themes work and get the Windows and Mac themes ready. Before we adjust the Linux theme we want to be sure that the Eclipse community approves the made changes and incorporate their feedback. Once Windows and Mac are finished we are fully committed to update the Linux theme.

[vogella]

Windows errors looks unrelated, merging