[GTK4] FileDialog with SWT.MULTI causes crash #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joel-majano
requested review from
sravanlakkimsetti and
akurtakov
as code owners
|
With this patch a user can now open a file and view it in Eclipse on GTK4. There is a crash that occurs after a while which I will open an issue for. |
In GTK3 gtk_file_chooser_get_files returns a GSList* but in GTK4, it retruns a GListModel*. The rest of the computeResultChooserDialog function assumes that we are dealing with a GSList which is incorrect. The fix is to adapt to the correct calls when dealing with GListModel. Tested with Eclipse IDE in GTK4 and Snippet72. Signed-off-by: Joel Majano <[email protected]>
akurtakov
force-pushed
the
multiFileDialogFixGTK4
branch
from
bbb966a
to
99e4a4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GTK3 gtk_file_chooser_get_files returns a GSList* but in GTK4, it retruns a GListModel*.
The rest of the computeResultChooserDialog function assumes that we are dealing with a GSList which is incorrect.
The fix is to adapt to the correct calls when dealing with GListModel.
Tested with Eclipse IDE in GTK4 and Snippet72.
Signed-off-by: Joel Majano [email protected]
Tracked in #228, Fixes #343