Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win32: Update Validate_SetPreferredAppMode for Arm64 24H2 #1765

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

sratz
Copy link
Member

@sratz sratz commented Jan 26, 2025

Fixes #1763.

@sratz sratz requested a review from SyntevoAlex January 26, 2025 21:05
Copy link
Contributor

Test Results

   494 files  ±0     494 suites  ±0   10m 34s ⏱️ + 1m 39s
 4 331 tests ±0   4 318 ✅ ±0   13 💤 ±0  0 ❌ ±0 
16 572 runs  ±0  16 464 ✅ ±0  108 💤 ±0  0 ❌ ±0 

Results for commit b4893c1. ± Comparison against base commit 6d374d9.

@chirontt
Copy link
Contributor

FYI: I've merged this change to my local working directory of this repo, and tested it using the snippet Bug562043_DarkTableNoHover.java and it is working fine i.e. the scrollbars are now dark as expected:

image

@sratz
Copy link
Member Author

sratz commented Jan 27, 2025

I've merged this change to my local working directory of this repo, and tested it using the snippet Bug562043_DarkTableNoHover.java and it is working fine i.e. the scrollbars are now dark as expected

Thanks for testing!

Let's merge this now then for M3 (test failures are unrelated).

@sratz sratz removed the request for review from SyntevoAlex January 27, 2025 09:23
@sratz sratz merged commit affce53 into eclipse-platform:master Jan 27, 2025
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrollbars in Dark Theme broken on Windows Arm64 version 24H2
2 participants