[GTK4] Migrate deprecated ColorChooser to ColorDialog #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GTK3:
GTK4:
|
ptziegler
commented
Nov 28, 2024
Comment on lines
+142
to
+149
| // TODO The color dialog isn't opened a non-modal window. However, the | ||
| // "same" API is used for e.g. the Font Dialog, where everything works. | ||
| // So this looks like a bug within GTK... | ||
| // Error: | ||
| // g_object_new_valist: invalid object type 'SwtFixed' for value type 'GtkWindow' | ||
| // GtkDialog mapped without a transient parent. This is discouraged. | ||
| GTK4.gtk_color_dialog_set_modal(handle, true); | ||
| GTK4.gtk_color_dialog_set_title(handle, buffer); |
There was a problem hiding this comment.
The "SwtFixed" is obviously something that comes from SWT, but I don't really understand how it works or why it's needed. And given that this doesn't cause issues for the Font Dialog, where I use same shell, I fail to see why it works in one but not the other...
ptziegler
commented
Nov 28, 2024
Comment on lines
+163
to
+167
| // TODO The ColorDialog API doesn't support setting a custom palette | ||
| // See https://gitlab.gnome.org/GNOME/gtk/-/issues/5936 | ||
| // > The new GtkColorDialog api doesn't have this feature atm. We might | ||
| // > want to bring it back, but judging from application use of color | ||
| // > choosers, setting custom palettes is not very popular. |
There was a problem hiding this comment.
This is probably really bad. But as mentioned in the linked issue, as well as the documentation, there is simply no way to customize the palette.
Meaning this is probably something that would first have to be implemented, but I don't think my GTK knowledge is sufficient to do so. :/
ptziegler
force-pushed
the
gtk4-color-dialog
branch
from
7a4a404 to
6cd388f
Compare
The Color Chooser has been moved to the GTK3 class and all references inside the GTK4 blocks have been updated to use the new API. Note that the GTK4 API doesn't provide the means to set a custom palette, meaning that the colors specified with setRGBS(RGB[]) are effectively ignored.
HannesWell
force-pushed
the
gtk4-color-dialog
branch
from
6cd388f to
c5f57d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Color Chooser has been moved to the GTK3 class and all references inside the GTK4 blocks have been updated to use the new API.
Note that the GTK4 API doesn't provide the means to set a custom palette, meaning that the colors specified with setRGBS(RGB[]) are effectively ignored.