Remove getZoomForAutoscaleProperty calls for win32 #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amartya4256
force-pushed
the
remove_getZoomForAutoscaleProperty_calls
branch
from
01cd52e
to
6047226
Compare
|
This seems to have stalled. Is it still needed? |
|
Yes, this is still under investigation for Windows HiDPI support. @amartya4256 can you please add a short documentation to this PR explaining what it is supposed to do/evaluate? |
|
@HeikoKlare I have updated the description, but the work is on halt right now since we have to figure out the image scaling issue first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to the removal of getZoomForAutoscaleProperty calls for win32 which is used to have the right zoom level for the widgets based on what the native zoom of the monitor is. However, this method is only needed for images and the rest can be taken care of by the Layout Manager while using native zoom.
contributes #62 and #127