-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict getting the restore process start time to CRaC API #20262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fyi @tajila |
OMR issue: eclipse-omr/omr#7469 |
tajila
approved these changes
Sep 30, 2024
tajila
added this to the Release 0.48 (Java 8, 11, 17, 21, 23) October refresh milestone
Sep 30, 2024
jenkins test sanity zlinux jdk21 |
jenkins test sanity xlinux jdk17 |
|
This test has been removed, but I hadn't removed if from the Edit: I've removed it now. |
There is a race condition on the existence of the criu restore process and retrieving its start time, when --restore-detached is passed to criu restore. This patch restrict retrieving the process start time to restoring via CRaC which is not affected. Issues: eclipse-openj9#20214 Signed-off-by: Nathan Henderson <[email protected]>
ThanHenderson
force-pushed
the
liberty-ppid
branch
from
October 1, 2024 15:18
cbc2ae0
to
c402180
Compare
We only need to restart the |
jenkins test sanity.functional xlinux jdk17 |
jenkins test sanity.functional zlinux jdk21 |
@ThanHenderson Please add a PR for 0.48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race condition on the existence of the
criu restore
process and retrieving its start time, when--restore-detached
is passed tocriu restore
. This patch restrict retrieving the process start time to restoring via CRaC which is not affected.Issues: #20214
Signed-off-by: Nathan Henderson [email protected]