Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds yield instruction for Power #7604

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Adds yield instruction for Power #7604

merged 1 commit into from
Jan 15, 2025

Conversation

IBMJimmyk
Copy link
Contributor

Adds properties for the yield instruction on Power.

Also adds binary encoder tests for yield.

@IBMJimmyk
Copy link
Contributor Author

@zl-wang Can you take a look at this when you get the chance?

@IBMJimmyk IBMJimmyk mentioned this pull request Jan 10, 2025
Merged
zl-wang
zl-wang approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@zl-wang zl-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest adding in the description something like: effective only on certain implementations

@zl-wang
Copy link
Contributor

zl-wang commented Jan 10, 2025

@dsouzai please review/approve/merge

@IBMJimmyk
Adds yield instruction for Power
ace6629 
Adds properties for the yield instruction for Power.

Also adds binary encoder tests for yield.

Signed-off-by: jimmyk <[email protected]>
@IBMJimmyk
Copy link
Contributor Author

I added extra comments.

@dsouzai
Copy link
Contributor

dsouzai commented Jan 13, 2025

jenkins build plinux,aix

@IBMJimmyk
Copy link
Contributor Author

It looks like a PPCDirectEncodingTest test failed which might be related to my change. I am looking at it now.

@IBMJimmyk
Copy link
Contributor Author

I'm not sure if the failure is related to my change or not. I'm not seeing anything wrong with my change.

The test failure looks like this:

09:42:30  31: �[0;32m[----------] �[m16 tests from Special/PPCDirectEncodingTest
09:42:30  31: free(): invalid next size (normal)
09:42:30  31/31 Test #31: compunittest ......................Child aborted***Exception:   0.83 sec

The encoding test also passes on AIX and I think the test should fail there as well if it was a problem I introduced.

@IBMJimmyk
Copy link
Contributor Author

@dsouzai Would it be possible to try restarting the failing test to see if it works now?

@dsouzai
Copy link
Contributor

dsouzai commented Jan 15, 2025

Sorry, I was supposed to comment on this but it slipped my mind. I believe the error is due to #6571.

@dsouzai dsouzai merged commit 0e72488 into eclipse-omr:master Jan 15, 2025
2 of 3 checks passed
@IBMJimmyk IBMJimmyk deleted the onSpinWait branch January 15, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zl-wang zl-wang zl-wang approved these changes

@dsouzai dsouzai dsouzai approved these changes

@mstoodle mstoodle Awaiting requested review from mstoodle mstoodle is a code owner

@0xdaryl 0xdaryl Awaiting requested review from 0xdaryl 0xdaryl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IBMJimmyk @zl-wang @dsouzai