Modifications to ensure compatibility with OpenXL and xlC on AIX #7561
Conversation
midronij
requested review from
babsingh,
vijaysun-omr,
dsouzai,
0xdaryl and
mstoodle
as code owners
|
@zl-wang here is the new OpenXL PR for OMR. Marked as a WIP since I'm still addressing the remaining review comments from Ishita's PRs |
midronij
force-pushed
the
openxl-final
branch
from
5340b8e to
7615492
Compare
|
I've just finished addressing the review comments from the previous version of this PR. @keithc-ca @zl-wang when you have a moment could you take a look to ensure that I didn't miss anything/provide any further feedback? |
configure
Outdated
| CC="$ac_save_CC $ac_arg" | ||
| if ac_fn_c_try_compile "$LINENO"; then : | ||
| ac_cv_prog_cc_c89=$ac_arg | ||
| if [ "$OMR_ENV_OPENXL" == "1" ]; then |
There was a problem hiding this comment.
This file should be derived from configure.ac (which is not modified by this change).
How would OMR_ENV_OPENXL be defined? (Hint: it's not from OmrDetectSystemInformation.cmake).
There was a problem hiding this comment.
I'm not sure if this is the solution you have in mind, but I opted to replace the check on OMR_ENV_OPENXL with the following condition:
if [[ "$CC" =~ 'ibm-clang' ]] && [[ "$CXX" =~ 'ibm-clang' ]]; then
since CC and CXX are both used in configure.ac, and when OpenXL being used, they should be set to the following:
* C Compiler: Version 17.0.6 (at /opt/IBM/openxlC/17.1.2/bin/ibm-clang_r)
* C++ Compiler: Version 17.0.6 (at /opt/IBM/openxlC/17.1.2/bin/ibm-clang++_r)
Is this a viable alternative?
There was a problem hiding this comment.
watch out for possible conflict with zOS using wyvern compiler:
- do they have the same names?
- if yes, can they use whatever under that condition?
There was a problem hiding this comment.
The zOS installation of OpenXL does indeed use the same name. And I don't think there's anything under that condition that's incompatible with zOS, but I will test that out before we proceed just to make sure.
midronij
force-pushed
the
openxl-final
branch
3 times, most recently
from
c1a8ebd to
d3634f0
Compare
midronij
changed the title
midronij
force-pushed
the
openxl-final
branch
from
d3634f0 to
d5cd947
Compare
To ensure that OMR can be built on AIX with both OpenXL and xlC, make modifications to compiler flags, macros, and linked libraries. Signed-off-by: midronij <[email protected]>
Initialize nlen, tindex, and myTag in TR_PPCTableOfConstants::lookUp() to prevent unexpected behavior when building with OpenXL on AIX. Signed-off-by: midronij <[email protected]>
midronij
force-pushed
the
openxl-final
branch
from
9e8ec74 to
62621c9
Compare
|
jenkins build all |
|
Windows and z/OS builds failed due to a lack of machines. RV ran into some groovy error Jenkins build riscv |
|
The RV problem happened again, but it looks like it's been happening in other PR builds as well |
Modify compiler flags, macros, and linked libraries to ensure that OMR can be built with both OpenXL and xlC on AIX.
Updated version of #7447 and #7480