-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OffHeap Changes #7345
OffHeap Changes #7345
Conversation
Failure in CI JitBuilder testing, looking into it
|
5f77115
to
68eb4f7
Compare
Fixed |
For the loop versioner commit, I would like @jdmpapin to also review. There is a typo in that loop versioner commit message : "to use the chilid of aloadi tree" |
9b3ed63
to
64c208b
Compare
Changes for enabling pinning array for all nodes causes a failure now, looking at it. |
64c208b
to
4c005f6
Compare
I updated the VPHandler code and added comments, please review changes. |
The additional comments and changes help. The code looks somewhat easier to follow. I'll wait for Devin's review as well |
4c005f6
to
9d90a9b
Compare
9d90a9b
to
4a70b75
Compare
4a70b75
to
12d2b87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loop versioner changes LGTM, but there may be a small piece missing. I also have a couple of comments about findArrayIndexNode()
12d2b87
to
24f6534
Compare
Also remove unused findArrayIndexNode from VP constrainAddressRef Signed-off-by: Shubham Verma <[email protected]>
Teaches LoopVersioner about dataAddr loads Whenever we see a dataAddrPointer; all tests gets generated, for null and array type, to use the child of the aloadi tree. Fix `depsForLoopEntryPrep` tree pattern matching to allow for array accesses to the 1st element using the dataAddrPointer, as that case does not have an offset tree. Fixing `requiresPrivatization()` to return false for dataAddr nodes as they are internal-pointers. Getting `childInRequiredForm` for the offheap case accessed the wrong node with an extra `getFirstChild()` at the end. Signed-off-by: Abdulrahman Alattas <[email protected]>
Use node extentions to store pinning array pointer for non add nodes. Signed-off-by: Shubham Verma <[email protected]>
24f6534
to
4a10457
Compare
Jenkins build all |
Checks have passed. Merging. |
Changes to support OffHeap