Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement METHOD STATS verbose output #7309

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

gita-omr
Copy link
Contributor

@gita-omr gita-omr commented Apr 11, 2024

  • introduce new verbose tag: "#METHOD STATS"
  • print "key=value" pairs for each method where "key" is an arbitrary string
  • values can be agrregated across all methods by a parsing script
  • this format can be used for an arbitrary info about a compiled method
  • in particular, introduce a function that prints various footprint
    stats for a method

@gita-omr
Copy link
Contributor Author

Fixed EOF error.

@gita-omr
Copy link
Contributor Author

Fixed Windows build.

@gita-omr
Copy link
Contributor Author

More fixes for Windows build.

Copy link
Contributor

@dsouzai dsouzai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions and minor changes requested.

compiler/codegen/OMRCodeGenerator.hpp Outdated Show resolved Hide resolved
compiler/control/OMROptions.hpp Outdated Show resolved Hide resolved
compiler/x/codegen/OMRCodeGenerator.cpp Outdated Show resolved Hide resolved
compiler/x/codegen/OMRCodeGenerator.cpp Outdated Show resolved Hide resolved
compiler/codegen/OMRCodeGenerator.cpp Outdated Show resolved Hide resolved
@gita-omr
Copy link
Contributor Author

Addressed comments above.

@gita-omr
Copy link
Contributor Author

Documented getMethodStats().

Copy link
Contributor

@dsouzai dsouzai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsouzai
Copy link
Contributor

dsouzai commented Apr 12, 2024

jenkins build all

@dsouzai
Copy link
Contributor

dsouzai commented Apr 12, 2024

aix and zos builds are failing because of

09:58:01  "/home/omr/workspace/Build/compiler/infra/OMRCfg.cpp", line 72.4: 1540-0063 (S) The text "{" is unexpected.

I guess you need to do

OMR::CFG::blockFrequencyNames[NUMBER_BLOCK_FREQUENCIES] =

- introduce new verbose tag: "#METHOD STATS"
- print "key=value" pairs for each method where "key" is an arbitrary string
- values can be agrregated across all methods by a parsing script
- this format can be used for an arbitrary info about a compiled method
- in particular, introduce a function that prints various footprint
  stats for a method
@gita-omr
Copy link
Contributor Author

Fixed missing "="

@dsouzai
Copy link
Contributor

dsouzai commented Apr 12, 2024

jenkins build all

@dsouzai
Copy link
Contributor

dsouzai commented Apr 12, 2024

riscv failure is due to #7291

@dsouzai
Copy link
Contributor

dsouzai commented Apr 12, 2024

osx build actually passed, but seems to be running because of a jenkins issue:

11:47:57  100% tests passed, 0 tests failed out of 49
11:47:57  
11:47:57  Total Test time (real) = 354.30 sec
[Pipeline] junit
11:47:58  Recording test results
11:48:17  [Checks API] No suitable checks publisher found.
[Pipeline] }
[Pipeline] // dir
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // timeout
[Pipeline] cleanWs
11:48:18  [WS-CLEANUP] Deleting project workspace...
11:48:18  [WS-CLEANUP] Deferred wipeout is used...
11:48:18  [WS-CLEANUP] done
[Pipeline] }
[Pipeline] // ws
[Pipeline] }
[Pipeline] // node
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // timeout
[Pipeline] }
[Pipeline] // timestamps
[Pipeline] End of Pipeline
Setting status of 9b1658a94b1e65d7fb00d719039e88a622c98ff9 to SUCCESS with url https://ci.eclipse.org/omr/job/PullRequest-osx_x86-64/3485/ and message: 'Build finished. '
Using context: continuous-integration/eclipse-omr/pr/osx_x86-64
Could not update commit status of the Pull Request on GitHub.
org.kohsuke.github.HttpException
	at org.kohsuke.github.GitHubConnectorResponseErrorHandler$1.onError(GitHubConnectorResponseErrorHandler.java:62)
	at org.kohsuke.github.GitHubClient.detectKnownErrors(GitHubClient.java:504)
	at org.kohsuke.github.GitHubClient.sendRequest(GitHubClient.java:464)
	at org.kohsuke.github.GitHubClient.sendRequest(GitHubClient.java:427)
	at org.kohsuke.github.Requester.fetch(Requester.java:85)
	at org.kohsuke.github.GHRepository.createCommitStatus(GHRepository.java:2297)
	at org.jenkinsci.plugins.ghprb.extensions.status.GhprbSimpleStatus.createCommitStatus(GhprbSimpleStatus.java:283)
	at org.jenkinsci.plugins.ghprb.extensions.status.GhprbSimpleStatus.onBuildComplete(GhprbSimpleStatus.java:241)
	at org.jenkinsci.plugins.ghprb.GhprbBuilds.onCompleted(GhprbBuilds.java:205)
	at org.jenkinsci.plugins.ghprb.GhprbBuildListener.onCompleted(GhprbBuildListener.java:28)
	at hudson.model.listeners.RunListener.lambda$fireCompleted$0(RunListener.java:207)
	at jenkins.util.Listeners.lambda$notify$0(Listeners.java:59)
	at jenkins.util.Listeners.notify(Listeners.java:67)
	at hudson.model.listeners.RunListener.fireCompleted(RunListener.java:205)
	at org.jenkinsci.plugins.workflow.job.WorkflowRun.finish(WorkflowRun.java:645)
	at org.jenkinsci.plugins.workflow.job.WorkflowRun$GraphL.onNewHead(WorkflowRun.java:1068)
	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.notifyListeners(CpsFlowExecution.java:1560)
	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$3.run(CpsThreadGroup.java:512)
	at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$1.run(CpsVmExecutorService.java:41)
	at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:139)
	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:68)
	at jenkins.util.ErrorLoggingExecutorService.lambda$wrap$0(ErrorLoggingExecutorService.java:51)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:839)
Finished: SUCCESS

@dsouzai
Copy link
Contributor

dsouzai commented Apr 12, 2024

azure macos failure is a known issue.

@dsouzai dsouzai merged commit 2f492f4 into eclipse-omr:master Apr 12, 2024
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants