Replace prism with shiki #253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lotes
reviewed
Oct 1, 2024
|
|
||
| // This isn't a particularly smart query implementation, | ||
| // so lets take the simple route and just grab all of the pre tags | ||
| const codeBlocks = dom.querySelectorAll("pre") |
There was a problem hiding this comment.
Very pragmatic :D... but what about a more official way? Are there no shiki plugins or addons for Hugo?
I googled it and discovered your source for this code:
https://blog.puzzmo.com/posts/2024/06/23/shiki-hugo/
We should add a link in case of any improvements in their comments (Maybe we have some trouble with this code, then it is good to look up this link first).
WDYT?
Lotes
reviewed
Oct 1, 2024
| @@ -4,12 +4,14 @@ | |||
| "author": "TypeFox", | |||
| "license": "MIT", | |||
| "private": true, | |||
| "type": "module", | |||
There was a problem hiding this comment.
This destroys the link checking build step :-/...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #244
Allows us to more easily highlight our custom code (like the
minilogolanguage and other in our documentation), using textmate instead of prism. Highlighting our custom code can be done in a separate PR, this only highlights the already existing code.