Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating Kuksa Go Client from kuksa.val #6

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

erikbosch
Copy link
Contributor

@erikbosch erikbosch commented Mar 22, 2024

Previously in https://github.com/eclipse/kuksa.val

For now I opted to have local copies of the proto-files, the alternative would be to have databroker as a submodule but that is maybe not that feasible for this repo.

erikbosch added a commit to boschglobal/kuksa.val that referenced this pull request Mar 22, 2024
erikbosch added a commit to boschglobal/kuksa.val that referenced this pull request Mar 22, 2024
@erikbosch erikbosch force-pushed the erik_go branch 2 times, most recently from ffb24e0 to 677593d Compare March 22, 2024 15:21
Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the good news:

I compiled and ran agains databroker: Works

Several .go files don"t seem to be having SPDX identifiers, we should fix it, as Ihave noticed it.

Question

  • shall we also add SPDX check in this repo? Even though it is incubation, projects might "graduate" out of here, and it would be a good and easy rain check to be sure, everything is "up to code" in terms of licensing at least

// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPDX identifier missing

// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPDX

@erikbosch
Copy link
Contributor Author

So, the good news:

I compiled and ran agains databroker: Works

Several .go files don"t seem to be having SPDX identifiers, we should fix it, as Ihave noticed it.

Question

* shall we also add SPDX check in this repo? Even though it is incubation, projects might "graduate" out of here, and it would be a good and easy rain check to be sure, everything is "up to code" in terms of licensing at least

It would be quite easy to add SPDX, I could do that

@erikbosch erikbosch force-pushed the erik_go branch 2 times, most recently from 81376d8 to 8a48bb3 Compare March 26, 2024 11:48
@erikbosch
Copy link
Contributor Author

Headers updated to match one of the models in https://www.eclipse.org/projects/handbook/#ip-copyright-headers

@SebastianSchildt
Copy link
Contributor

I think the SPDX check does not understand/checks .go files crrect?

https://github.com/eclipse-kuksa/kuksa-actions/blob/main/spdx/verify-spdx-headers

If so, not strictly an issue with this PR, but should we repair it?

@erikbosch erikbosch marked this pull request as draft March 27, 2024 13:46
@erikbosch
Copy link
Contributor Author

Changing to draft for now to experiment with spdx checker

@erikbosch erikbosch force-pushed the erik_go branch 2 times, most recently from cd8f018 to a028818 Compare March 27, 2024 14:08
@erikbosch
Copy link
Contributor Author

An update to SPDX checker here: eclipse-kuksa/kuksa-actions#6

No change needed here, if we move the 2 tag of kuksa-actions as soon as the PR is merged we will onwards check also *.go files

@SebastianSchildt
Copy link
Contributor

I merged eclipse-kuksa/kuksa-actions#6 and retagged (2 and 2.5), and retriggered the SPDX check.

Looking good, but leave it up to you @erikbosch to "undraft" because not sure I missed anything

Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now 🏈

@erikbosch erikbosch marked this pull request as ready for review March 28, 2024 08:07
@erikbosch erikbosch merged commit ed56ee1 into eclipse-kuksa:main Mar 28, 2024
5 checks passed
@erikbosch erikbosch deleted the erik_go branch March 28, 2024 08:09
SebastianSchildt pushed a commit to eclipse/kuksa.val that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants