Fix "Redundant superinterface" warning depends on Interface name #3423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperTypeTest.test016(), SuperTypeTest.test017() failed when implementation of ReferenceBinding.hashCode() changed. The message was either "already defined by IChangeRulerColumn" or "already defined by IRevisionRulerColumn" depending on which Interface had the lower hashCode. Now using a LinkedHashMap to rely on the insertion order rather then the hashcode. relates to eclipse-jdt#3412
|
Thanks @jukzi I'll review this tomorrow |
srikanth-sankaran
approved these changes
Dec 11, 2024
|
I tested manually with forcing specific hashCodes for both interfaces that both tests would change result upon changing hashcode. However the current solution does not change the hashCode but just does not rely on it anymore. Only one of the tests had in the "expected" order, i adapted the other. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SuperTypeTest.test016(), SuperTypeTest.test017() failed when implementation of ReferenceBinding.hashCode() changed.
The message was either
"already defined by IChangeRulerColumn" or
"already defined by IRevisionRulerColumn"
depending on which Interface had the lower hashCode.
Now using a LinkedHashMap to rely on the insertion order rather then the hashcode.
relates to
#3412