Sealed and non-sealed modifiers and permitted types not accessible through ITypeBinding #3252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for sealed and non-sealed modifiers
subyssurendran666
force-pushed
the
sealed-modifiers-and-permitted-types-not-accessible-through-ITypeBinding-3178
branch
from
e45f07a
to
178a88c
Compare
jarthana
requested changes
Nov 6, 2024
| if (referenceBinding.isAnonymousType()) { | ||
| return accessFlags & ~Modifier.FINAL; | ||
| } else if (referenceBinding.isSealed()) { | ||
| return Modifier.SEALED; |
There was a problem hiding this comment.
This is wrong. With this, we are discarding every other bit in accessFlags.
| } else if (referenceBinding.isSealed()) { | ||
| return Modifier.SEALED; | ||
| } else if (referenceBinding.isNonSealed()) { | ||
| return Modifier.NON_SEALED; |
| @@ -133,4 +127,64 @@ void main() { | |||
| assertEquals("Not a Block", block.getNodeType(), ASTNode.BLOCK); | |||
| assertEquals("Block startPosition is not correct", block.getStartPosition(), 21); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Would help if you can select just the newly added code block and format, to keep it in line with our formatting preferences.
| astParser.setBindingsRecovery(true); | ||
|
|
||
| String source =""" | ||
| sealed class A permits B, C {} |
There was a problem hiding this comment.
You might want to add some more modifiers and test for their presence in the output. For e.g.
public sealed abstract class A permits B, C {}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the unit tests and added the modifiers to the resolve bindings for sealed and non-sealed modifiers
What it does
The 'sealed' and 'non-sealed' modifiers are visible and accessible through the AST, but not when trying to get the same information with the associated type binding. Therefore added the modifiers in the TypeBiding for the sealed and non-sealed modifiers.
How to test
This PR closes #3178
Author checklist