Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systematic maintenance of jclMinX.jar and .src.zip #3223

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

stephan-herrmann
Copy link
Contributor

  • remove jclMin < 1.8 and adjust ClasspathTests accordingly
  • created jclMin projects from existing jclMin*src.zip
  • added module-info to all modular jcl
  • declared --patch-module in .classpath & build.xml
  • minor clean-up
  • regenerate all jclMin
  • did NOT re-generate converterJclMin - need to check diffs first
  • fix source attachment for jclFull1.8.jar

Fixes #2727

+ remove jclMin < 1.8 and adjust ClasspathTests accordingly
+ created jclMin projects from existing jclMin*src.zip
+ added module-info to all modular jcl
+ declared --patch-module in .classpath & build.xml
+ minor clean-up
+ regenerate all jclMin
+ did NOT re-generate converterJclMin - need to check diffs first
+ fix source attachment for jclFull1.8.jar

Fixes eclipse-jdt#2727
@stephan-herrmann
Copy link
Contributor Author

No rocket science, just a bunch of eclipse projects and additions to the existing build.xml.

As we still keep the resulting .jar and .zip in git, rebuilding has to be triggered on every change.

It will be interesting to see, if regenerating on different machines will result in changes of artifacts where the source where not touched.

Currently the ant build will actually pick up .class files created by ecj in the IDE, so perhaps a new version of ecj may create differences in class files.

One issue to highlight: for levels 9+ we would normally get a conflict with module java.base, since we still need to link a JRE for building. I solved this by --patch-module java.base=src both in .classpath and build.xml. I was actually surprised to see, that I was still allowed to add module-info.java declaring that vary module java.base. Interesting.

@stephan-herrmann stephan-herrmann merged commit 1150dc0 into eclipse-jdt:master Nov 3, 2024
10 checks passed
@stephan-herrmann stephan-herrmann deleted the issue2727 branch November 3, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Systematic maintenance of jclMinX.jar and .src.zip
1 participant