Skip to content

Commit

Permalink
fix compilation errors
Browse files Browse the repository at this point in the history
  • Loading branch information
ndr-brt committed Oct 28, 2024
1 parent 9cb54f6 commit d95a134
Show file tree
Hide file tree
Showing 7 changed files with 41 additions and 57 deletions.
2 changes: 2 additions & 0 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ awaitility = { module = "org.awaitility:awaitility", version.ref = "awaitility"
edc-api-observability = { module = "org.eclipse.edc:api-observability", version.ref = "edc" }
edc-auth-tokenbased = { module = "org.eclipse.edc:auth-tokenbased", version.ref = "edc" }
edc-boot = { module = "org.eclipse.edc:boot", version.ref = "edc" }
edc-bom-controlplane-base = { module = "org.eclipse.edc:controlplane-base-bom", version.ref = "edc" }
edc-bom-dataplane-base = { module = "org.eclipse.edc:dataplane-base-bom", version.ref = "edc" }
edc-build-plugin = { module = "org.eclipse.edc.edc-build:org.eclipse.edc.edc-build.gradle.plugin", version.ref = "edc" }
edc-configuration-filesystem = { module = "org.eclipse.edc:configuration-filesystem", version.ref = "edc" }
edc-connector-core = { module = "org.eclipse.edc:connector-core", version.ref = "edc" }
Expand Down
35 changes: 18 additions & 17 deletions policy/policy-01-policy-enforcement/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,25 +37,25 @@ When creating a rule binding, we can bind an action type or constraint to either
Here, we bind the action type `use` to all scopes, so that rules with this action type are always evaluated. For the
location constraint we choose the negotiation scope, meaning it will only be evaluated during the contract negotiation.
Information on available scopes can be found
[here](https://github.com/eclipse-edc/Connector/blob/main/docs/developer/policy-engine.md).
[here](https://eclipse-edc.github.io/documentation/for-adopters/control-plane/policy-engine/).

### Implementing the function for evaluation

With the rule bindings in place, the provider will now try to evaluate our policy including the constraint during a
contract negotiation, but it does not yet know *how* to evaluate this constraint. For this, we need to implement a
function, for which the EDC offer two interfaces: `AtomicConstraintFunction` and `RuleFunction`. The former is meant
for evaluating a single constraint of a rule, while is latter is meant for evaluating a complete rule node (including
constraints as well as duties that may be associated with a permission). For our example, we choose to implement an
`AtomicConstraintFunction`, as we want to evaluate our location constraint:
function, for which the EDC offer two interfaces: `AtomicConstraintRuleFunction` and `PolicyRuleFunction`. The former is
meant for evaluating a single constraint of a rule, while is latter is meant for evaluating a complete rule node
(including constraints as well as duties that may be associated with a permission). For our example, we choose to
implement an `AtomicConstraintRuleFunction`, as we want to evaluate our location constraint:

```java
public class LocationConstraintFunction implements AtomicConstraintFunction<Permission> {
public class LocationConstraintFunction implements AtomicConstraintRuleFunction<Permission, ContractNegotiationPolicyContext> {

//...

@Override
public boolean evaluate(Operator operator, Object rightValue, Permission rule, PolicyContext context) {
var region = context.getContextData(ParticipantAgent.class).getClaims().get("region");
public boolean evaluate(Operator operator, Object rightValue, Permission rule, ContractNegotiationPolicyContext context) {
var region = context.participantAgent().getClaims().get("region");

monitor.info(format("Evaluating constraint: location %s %s", operator, rightValue.toString()));

Expand All @@ -70,12 +70,13 @@ public class LocationConstraintFunction implements AtomicConstraintFunction<Perm
```

When implementing either of the function interfaces, we have to override the `evaluate` method. For the
`AtomicConstraintFunction` we get the constraint's operator and right value as well as the containing rule node and
a `PolicyContext` as parameters. Using these, we have to determine whether the constraint is fulfilled. Since we want
to check the requesting participant's location, we need to access information about the participant. This is supplied
through the `PolicyContext`. We get the participant's claim with key *region* to obtain information about the
participant's location. We can then compare the location to the expected value depending on the operator used. The
function should return true, if the constraint is fulfilled, and false otherwise.
`AtomicConstraintRuleFunction` we get the constraint's operator and right value as well as the containing rule node and
an extension of `PolicyContext` as parameters, determined by the policy scope on which the function the function will be
registered (keep in mind that policy scopes and contexts are strictly bound to each other). Using these, we have to
determine whether the constraint is fulfilled. Since we want to check the requesting participant's location, we need to
access information about the participant. This is supplied through the context. We get the participant's claim with key
*region* to obtain information about the participant's location. We can then compare the location to the expected value
depending on the operator used. The function should return true, if the constraint is fulfilled, and false otherwise.

**Note**: we can use the *region* claim here because our connectors use the `iam-mock` extension, which always adds
a claim with this exact name to all tokens. Depending on the identity provider used, different claims may be present,
Expand All @@ -87,14 +88,14 @@ After creating our function for evaluation, the last thing we need to do is regi
`PolicyEngine`, so that it is available for evaluation:

```java
policyEngine.registerFunction(NEGOTIATION_SCOPE, Permission.class, LOCATION_CONSTRAINT_KEY, new LocationConstraintFunction(monitor));
policyEngine.registerFunction(ContractNegotiationPolicyContext.class, Permission.class, LOCATION_CONSTRAINT_KEY, new LocationConstraintFunction(monitor));
```

When registering the function, we again have to specify a scope. This allows for evaluating the same rule or
When registering the function, we again have to specify a context class. This allows for evaluating the same rule or
constraint differently in different runtime contexts. Since we bound our constraint to the negotiation scope, we also
register our function for that scope. Next, we need to specify the type of rule our function should be used for. This
is important, as the same constraint may have different implications as part of a permission, prohibition or duty.
When registering an `AtomicConstraintFunction`, we also have to specify a key that the function is associated with.
When registering an `AtomicConstraintRuleFunction`, we also have to specify a key that the function is associated with.
This has to resolve to exactly the constraint's left operand, so that the correct function for evaluation of a
constraint can be chosen depending on its left operand. So we set the key to the same value we used as our constraint's
left operand. And lastly, we hand over an instance of our function.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,18 @@

package org.eclipse.edc.sample.extension.policy;

import org.eclipse.edc.policy.engine.spi.AtomicConstraintFunction;
import org.eclipse.edc.policy.engine.spi.PolicyContext;
import org.eclipse.edc.connector.controlplane.contract.spi.policy.ContractNegotiationPolicyContext;
import org.eclipse.edc.policy.engine.spi.AtomicConstraintRuleFunction;
import org.eclipse.edc.policy.model.Operator;
import org.eclipse.edc.policy.model.Permission;
import org.eclipse.edc.spi.agent.ParticipantAgent;
import org.eclipse.edc.spi.monitor.Monitor;

import java.util.Collection;
import java.util.Objects;

import static java.lang.String.format;

public class LocationConstraintFunction implements AtomicConstraintFunction<Permission> {
public class LocationConstraintFunction implements AtomicConstraintRuleFunction<Permission, ContractNegotiationPolicyContext> {

private final Monitor monitor;

Expand All @@ -35,8 +34,8 @@ public LocationConstraintFunction(Monitor monitor) {
}

@Override
public boolean evaluate(Operator operator, Object rightValue, Permission rule, PolicyContext context) {
var region = context.getContextData(ParticipantAgent.class).getClaims().get("region");
public boolean evaluate(Operator operator, Object rightValue, Permission rule, ContractNegotiationPolicyContext context) {
var region = context.participantAgent().getClaims().get("region");

monitor.info(format("Evaluating constraint: location %s %s", operator, rightValue.toString()));

Expand All @@ -47,4 +46,4 @@ public boolean evaluate(Operator operator, Object rightValue, Permission rule, P
default -> false;
};
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,15 @@

package org.eclipse.edc.sample.extension.policy;

import org.eclipse.edc.connector.controlplane.contract.spi.policy.ContractNegotiationPolicyContext;
import org.eclipse.edc.policy.engine.spi.PolicyEngine;
import org.eclipse.edc.policy.engine.spi.RuleBindingRegistry;
import org.eclipse.edc.policy.model.Permission;
import org.eclipse.edc.runtime.metamodel.annotation.Inject;
import org.eclipse.edc.spi.system.ServiceExtension;
import org.eclipse.edc.spi.system.ServiceExtensionContext;

import static org.eclipse.edc.connector.controlplane.contract.spi.validation.ContractValidationService.NEGOTIATION_SCOPE;
import static org.eclipse.edc.connector.controlplane.contract.spi.policy.ContractNegotiationPolicyContext.NEGOTIATION_SCOPE;
import static org.eclipse.edc.jsonld.spi.PropertyAndTypeNames.ODRL_USE_ACTION_ATTRIBUTE;
import static org.eclipse.edc.policy.engine.spi.PolicyEngine.ALL_SCOPES;
import static org.eclipse.edc.spi.constants.CoreConstants.EDC_NAMESPACE;
Expand All @@ -45,6 +46,6 @@ public void initialize(ServiceExtensionContext context) {

ruleBindingRegistry.bind(ODRL_USE_ACTION_ATTRIBUTE, ALL_SCOPES);
ruleBindingRegistry.bind(LOCATION_CONSTRAINT_KEY, NEGOTIATION_SCOPE);
policyEngine.registerFunction(ALL_SCOPES, Permission.class, LOCATION_CONSTRAINT_KEY, new LocationConstraintFunction(monitor));
policyEngine.registerFunction(ContractNegotiationPolicyContext.class, Permission.class, LOCATION_CONSTRAINT_KEY, new LocationConstraintFunction(monitor));
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,11 @@ plugins {
}

dependencies {
implementation(libs.edc.bom.controlplane.base)
implementation(libs.edc.control.api.configuration)
implementation(libs.edc.control.plane.api.client)
implementation(libs.edc.control.plane.core)
implementation(libs.edc.data.plane.selector.core)
implementation(libs.edc.api.observability)
implementation(libs.edc.configuration.filesystem)

implementation(libs.edc.iam.mock)
implementation(libs.edc.management.api)
implementation(libs.edc.dsp)
implementation(libs.edc.http)
implementation(libs.edc.data.plane.selector.api)
implementation(libs.edc.transfer.data.plane.signaling)
implementation(libs.edc.control.plane.api.client)
implementation(libs.edc.data.plane.spi)
implementation(libs.edc.data.plane.core)
implementation(libs.edc.data.plane.self.registration)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,11 @@ plugins {
}

dependencies {
implementation(libs.edc.bom.controlplane.base)
implementation(libs.edc.control.api.configuration)
implementation(libs.edc.control.plane.api.client)
implementation(libs.edc.control.plane.core)
implementation(libs.edc.data.plane.selector.core)
implementation(libs.edc.api.observability)
implementation(libs.edc.configuration.filesystem)

implementation(libs.edc.iam.mock)
implementation(libs.edc.management.api)
implementation(libs.edc.dsp)
implementation(libs.edc.http)
implementation(libs.edc.data.plane.selector.api)
implementation(libs.edc.transfer.data.plane.signaling)
implementation(libs.edc.control.plane.api.client)
implementation(libs.edc.data.plane.spi)
implementation(libs.edc.data.plane.core)
implementation(libs.edc.data.plane.self.registration)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,15 @@ plugins {
}

dependencies {
implementation(libs.edc.control.plane.api.client)
implementation(libs.edc.control.plane.core)
implementation(libs.edc.data.plane.selector.core)
implementation(libs.edc.api.observability)
implementation(libs.edc.configuration.filesystem)
implementation(libs.edc.iam.mock)
implementation(libs.edc.management.api)
implementation(libs.edc.dsp)
implementation(libs.edc.http)
implementation(libs.edc.data.plane.selector.api)
implementation(libs.edc.transfer.data.plane.signaling)
implementation(libs.edc.bom.controlplane.base)
implementation(libs.edc.control.api.configuration)
implementation(libs.edc.transfer.pull.http.dynamic.receiver)

implementation(libs.edc.iam.mock)
implementation(libs.edc.control.plane.api.client)
implementation(libs.edc.data.plane.spi)
implementation(libs.edc.data.plane.core)
implementation(libs.edc.data.plane.self.registration)
implementation(libs.edc.data.plane.http)
implementation(libs.edc.data.plane.kafka)
}
Expand Down

0 comments on commit d95a134

Please sign in to comment.