feat: allow customization of the STS Account's secret_alias #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
approved these changes
Oct 2, 2024
paullatzelsperger
force-pushed
the
feat/468_make_clientsecret_configurable
branch
from
81e17e5
to
83267d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR adds an extensible Map to the
ParticipantManifestto allow for additional parameters, such as customizing the alias under which the client_secret is stored in the vault.Why it does that
avoid potential conflicts in the vault, consistent configuration
Further notes
Linked Issue(s)
Closes #468
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.