chore: audience check with participant id or did #270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
force-pushed
the
chore/access_token_verifier_aud_fix
branch
from
172ef01
to
d27e3eb
Compare
wolf4ood
force-pushed
the
chore/access_token_verifier_aud_fix
branch
from
d27e3eb
to
7b712cc
Compare
wolf4ood
requested review from
paullatzelsperger and
bscholtes1A
and removed request for
paullatzelsperger
|
This pull request is stale because it has been open for 7 days with no activity. |
|
Is this still a draft? |
|
Yeah it's not enough this PR for being able to use a participantId different from a did for now. It's not with priority for now so probably i would just close this and create an issue that we tackle when we actually have a need |
|
This pull request is stale because it has been open for 7 days with no activity. |
|
This pull request was closed because it has been inactive for 7 days since being marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Changes the checks on participant id
AccessTokenVerifieraudcheck is tested against the participant id or the participant did